From: Chen Zhongjin <chenzhongjin@huawei.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: <alexander.sverdlin@nokia.com>, <ardb@kernel.org>,
<linus.walleij@linaro.org>, <nico@fluxnic.net>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] ARM: module: Add all unwind tables when load module
Date: Fri, 20 May 2022 15:53:21 +0800 [thread overview]
Message-ID: <59b140a2-fd9d-f5a7-85e0-9ff712e468df@huawei.com> (raw)
In-Reply-To: <YoOu1Ng53Tv/ec0d@shell.armlinux.org.uk>
On 2022/5/17 22:19, Russell King (Oracle) wrote:
> Hi,
>
> On Fri, Apr 01, 2022 at 09:15:34PM +0800, Chen Zhongjin wrote:
>> struct mod_arch_specific {
>> #ifdef CONFIG_ARM_UNWIND
>> - struct unwind_table *unwind[ARM_SEC_MAX];
>> + struct unwind_table unwind_list;
>
> Why is this not a:
>
> struct list_head unwind_list;
>
> because, from what I can tell, the _only_ member that is used in this
> struct unwind_table is the "mod_list" member - so everything else is
> entirely unused and redundant.
>
> Thanks.
>
Thanks for review!
I have updated it to v5 with two other fixes. Also updated it on patch tracker.
Best,
Chen
prev parent reply other threads:[~2022-05-20 7:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 13:15 Chen Zhongjin
2022-04-11 2:26 ` Chen Zhongjin
2022-04-20 3:37 ` Chen Zhongjin
2022-04-28 22:45 ` Linus Walleij
2022-04-29 3:17 ` Chen Zhongjin
2022-05-17 14:19 ` Russell King (Oracle)
2022-05-20 7:53 ` Chen Zhongjin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59b140a2-fd9d-f5a7-85e0-9ff712e468df@huawei.com \
--to=chenzhongjin@huawei.com \
--cc=alexander.sverdlin@nokia.com \
--cc=ardb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®