From: Andrzej Hajda <a.hajda@samsung.com>
To: Jeffy Chen <jeffy.chen@rock-chips.com>, linux-kernel@vger.kernel.org
Cc: Marek Vasut <marex@denx.de>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
briannorris@chromium.org, dianders@chromium.org,
dri-devel@lists.freedesktop.org, tfiga@chromium.org,
zyw@rock-chips.com, Yakir Yang <kuankuan.y@gmail.com>
Subject: Re: [PATCH v5 04/12] drm: bridge: analogix: Destroy connector & encoder when unbinding
Date: Fri, 07 Apr 2017 14:01:03 +0200 [thread overview]
Message-ID: <59da511f-5243-fffb-f366-a51807b04a20@samsung.com> (raw)
In-Reply-To: <1491481885-13775-5-git-send-email-jeffy.chen@rock-chips.com>
On 06.04.2017 14:31, Jeffy Chen wrote:
> Normally we do this in drm_mode_config_cleanup. But:
> 1/ analogix dp's connector is allocated in bind, and freed after unbind.
> So we need to destroy it in unbind to avoid further access.
> 2/ the drm bridge is attached in bind, and detached in encoder cleanup.
> So we need to destroy encoder in unbind.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
In general drm core should free drm resources, doing it in component can
hurt some day. Maybe it would be good to move some stuff from
bind/unbind to probe/remove if necessary, to allow connector and encoder
to live little bit longer, and be destroyed by drm core. This is just
suggestion, I am not familiar enough with the driver to make stronger
statements :)
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
>
> Changes in v5: None
> Changes in v4:
> Address Andrzej Hajda <a.hajda@samsung.com>'s comments.
>
> Changes in v3: None
> Changes in v2: None
>
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index d05ade4..4c758ed 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1439,6 +1439,8 @@ void analogix_dp_unbind(struct device *dev, struct device *master,
> struct analogix_dp_device *dp = dev_get_drvdata(dev);
>
> analogix_dp_bridge_disable(dp->bridge);
> + dp->connector.funcs->destroy(&dp->connector);
> + dp->encoder->funcs->destroy(dp->encoder);
>
> if (dp->plat_data->panel) {
> if (drm_panel_unprepare(dp->plat_data->panel))
next prev parent reply other threads:[~2017-04-07 12:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 12:31 [PATCH v5 00/12] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
2017-04-06 12:31 ` [PATCH v5 01/12] drm: bridge: analogix: Detach panel when unbinding analogix dp Jeffy Chen
2017-04-06 12:31 ` [PATCH v5 02/12] drm: bridge: analogix: Unregister dp aux when unbinding Jeffy Chen
2017-04-06 12:31 ` [PATCH v5 03/12] drm: bridge: analogix: Disable clock " Jeffy Chen
2017-04-07 11:32 ` Andrzej Hajda
2017-04-06 12:31 ` [PATCH v5 04/12] drm: bridge: analogix: Destroy connector & encoder " Jeffy Chen
2017-04-07 12:01 ` Andrzej Hajda [this message]
2017-04-06 12:31 ` [PATCH v5 05/12] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded Jeffy Chen
2017-04-06 12:31 ` [PATCH v5 06/12] drm/rockchip: cdn-dp: Don't unregister audio dev when unbinding Jeffy Chen
2017-04-06 12:31 ` [PATCH v5 07/12] drm/rockchip: vop: Enable pm domain before vop_initial Jeffy Chen
2017-04-06 12:31 ` [PATCH v5 08/12] drm/rockchip: vop: Unprepare clocks when unbinding Jeffy Chen
2017-04-06 12:31 ` [PATCH v5 09/12] drm/rockchip: analogix_dp: Disable clock " Jeffy Chen
2017-04-06 12:31 ` [PATCH v5 10/12] drm/rockchip: Reoder drm bind/unbind sequence Jeffy Chen
2017-04-06 12:31 ` [PATCH v5 11/12] drm/rockchip: Shutdown all crtcs when unbinding drm Jeffy Chen
2017-04-06 12:31 ` [PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered Jeffy Chen
2017-04-07 7:16 ` Daniel Vetter
2017-04-07 9:24 ` jeffy
2017-04-07 18:34 ` Daniel Vetter
2017-04-07 17:36 ` [PATCH v5 00/12] drm: rockchip: Fix rockchip drm unbind crash error Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59da511f-5243-fffb-f366-a51807b04a20@samsung.com \
--to=a.hajda@samsung.com \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jeffy.chen@rock-chips.com \
--cc=kuankuan.y@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=tfiga@chromium.org \
--cc=tomeu.vizoso@collabora.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®