mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Shaikh, Azhar" <azhar.shaikh@intel.com>
To: Javier Martinez Canillas <javierm@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	James Ettle <james@ettle.org.uk>,
	Hans de Goede <hdegoede@redhat.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	"Peter Huewe" <peterhuewe@gmx.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-integrity@vger.kernel.org"
	<linux-integrity@vger.kernel.org>
Subject: RE: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region
Date: Thu, 21 Dec 2017 16:34:16 +0000	[thread overview]
Message-ID: <5FFFAD06ADE1CA4381B3F0F7C6AF5828988FFF@ORSMSX109.amr.corp.intel.com> (raw)
In-Reply-To: <f1f61477-a0df-1072-9751-8e9c254856e2@redhat.com>



>-----Original Message-----
>From: Javier Martinez Canillas [mailto:javierm@redhat.com]
>Sent: Thursday, December 21, 2017 7:54 AM
>To: Shaikh, Azhar <azhar.shaikh@intel.com>; Jason Gunthorpe
><jgg@ziepe.ca>
>Cc: linux-kernel@vger.kernel.org; James Ettle <james@ettle.org.uk>; Hans de
>Goede <hdegoede@redhat.com>; Arnd Bergmann <arnd@arndb.de>; Jarkko
>Sakkinen <jarkko.sakkinen@linux.intel.com>; Peter Huewe
><peterhuewe@gmx.de>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>; linux-integrity@vger.kernel.org
>Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O
>memory region
>
>On 12/21/2017 04:39 PM, Shaikh, Azhar wrote:
>> HI Javier,
>>
>>
>>> -----Original Message-----
>>> From: linux-integrity-owner@vger.kernel.org [mailto:linux-integrity-
>>> owner@vger.kernel.org] On Behalf Of Javier Martinez Canillas
>>> Sent: Thursday, December 21, 2017 4:49 AM
>>> To: Shaikh, Azhar <azhar.shaikh@intel.com>; Jason Gunthorpe
>>> <jgg@ziepe.ca>
>>> Cc: linux-kernel@vger.kernel.org; James Ettle <james@ettle.org.uk>;
>>> Hans de Goede <hdegoede@redhat.com>; Arnd Bergmann
><arnd@arndb.de>;
>>> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>; Peter Huewe
>>> <peterhuewe@gmx.de>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>;
>>> linux-integrity@vger.kernel.org
>>> Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already
>>> unmapped I/O memory region
>>>
>>> Hello Azhar,
>>>
>>> On 12/20/2017 08:15 PM, Shaikh, Azhar wrote:
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Jason Gunthorpe [mailto:jgg@ziepe.ca]
>>>>> Sent: Wednesday, December 20, 2017 10:55 AM
>>>>> To: Javier Martinez Canillas <javierm@redhat.com>
>>>>> Cc: linux-kernel@vger.kernel.org; James Ettle <james@ettle.org.uk>;
>>>>> Hans de Goede <hdegoede@redhat.com>; Shaikh, Azhar
>>>>> <azhar.shaikh@intel.com>; Arnd Bergmann <arnd@arndb.de>; Jarkko
>>>>> Sakkinen <jarkko.sakkinen@linux.intel.com>; Peter Huewe
>>>>> <peterhuewe@gmx.de>; Greg Kroah-Hartman
>>> <gregkh@linuxfoundation.org>;
>>>>> linux- integrity@vger.kernel.org
>>>>> Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already
>>>>> unmapped I/O memory region
>>>>>
>>>>> On Wed, Dec 20, 2017 at 07:21:31PM +0100, Javier Martinez Canillas
>wrote:
>>>>>
>>>>>>> The below draft fixes everything except #1. That needs a more
>>>>>>> thoughtful idea..
>>>>>>>
>>>>>>
>>>>>> I'll just drop this patch from the series and you can fix all the
>>>>>> issues in the error / driver removal paths. It's not a dependency
>>>>>> anyways, I included it just because noticed the issue while
>>>>>> reading the
>>> code.
>>>>>
>>>>> Azhar, this means it becomes your problem :)
>>>>>
>>>>
>>>> Sure, I will fix this.
>>>> Javier you can drop this patch.
>>>>
>>>
>>> On a second though, we should just merge $SUBJECT since is an obvious
>>> fix for one of the issues. Then you could fix the remaining bugs in
>>> error and driver removal paths.
>>
>> I think you are asking to keep this patch as a part of this series, itself and not
>upload separately. Is this correct? Please correct me if I am wrong.
>>
>
>Yes, what I meant is that we should just keep this patch in the series since it
>fixes one of the resource cleanup bugs. Then you can fix the other issues as a
>follow-up.
>

Ok, but even the patch which I will be submitting will be doing the cleanup. So it will just split the change.


>Best regards,
>--
>Javier Martinez Canillas
>Software Engineer - Desktop Hardware Enablement Red Hat

Regards,
Azhar Shaikh 

  reply	other threads:[~2017-12-21 16:34 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-20 11:35 [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled Javier Martinez Canillas
2017-12-20 11:35 ` [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region Javier Martinez Canillas
2017-12-20 15:25   ` Shaikh, Azhar
2017-12-20 18:08   ` Jason Gunthorpe
2017-12-20 18:21     ` Javier Martinez Canillas
2017-12-20 18:54       ` Jason Gunthorpe
2017-12-20 19:15         ` Shaikh, Azhar
2017-12-21 12:48           ` Javier Martinez Canillas
2017-12-21 15:39             ` Shaikh, Azhar
2017-12-21 15:53               ` Javier Martinez Canillas
2017-12-21 16:34                 ` Shaikh, Azhar [this message]
2017-12-22 18:35   ` Jarkko Sakkinen
2017-12-24 20:57   ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 2/4] tpm: delete the TPM_TIS_CLK_ENABLE flag Javier Martinez Canillas
2017-12-20 15:19   ` Shaikh, Azhar
2017-12-20 18:10     ` Jason Gunthorpe
2017-12-20 18:26       ` Javier Martinez Canillas
2017-12-22 18:38         ` Jarkko Sakkinen
2017-12-22 18:33   ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 3/4] tpm: follow coding style for variable declaration in tpm_tis_core_init() Javier Martinez Canillas
2017-12-22 18:32   ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 4/4] tpm: only attempt to disable the LPC CLKRUN if is already enabled Javier Martinez Canillas
2017-12-22 18:36   ` Jarkko Sakkinen
2017-12-20 11:43 ` [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled Hans de Goede
2017-12-20 12:12   ` Javier Martinez Canillas
2017-12-20 14:07     ` Alexander.Steffen
2017-12-20 14:35       ` Javier Martinez Canillas
2017-12-20 15:08       ` Shaikh, Azhar
2017-12-20 15:31         ` Javier Martinez Canillas
2017-12-20 15:41           ` Shaikh, Azhar
2017-12-20 16:45             ` Javier Martinez Canillas
2017-12-20 17:44               ` Jason Gunthorpe
2017-12-20 18:33                 ` Javier Martinez Canillas
2017-12-22 18:39   ` Jarkko Sakkinen
2017-12-21 10:51 ` James Ettle
2017-12-21 12:46   ` Javier Martinez Canillas
2017-12-21 17:25     ` Jeffery Miller
2017-12-21 18:44       ` Javier Martinez Canillas
2017-12-21 19:02         ` Jeffery Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5FFFAD06ADE1CA4381B3F0F7C6AF5828988FFF@ORSMSX109.amr.corp.intel.com \
    --to=azhar.shaikh@intel.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=james@ettle.org.uk \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=javierm@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®