mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: "Shaikh, Azhar" <azhar.shaikh@intel.com>,
	"Alexander.Steffen@infineon.com" <Alexander.Steffen@infineon.com>,
	"hdegoede@redhat.com" <hdegoede@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "james@ettle.org.uk" <james@ettle.org.uk>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"jarkko.sakkinen@linux.intel.com"
	<jarkko.sakkinen@linux.intel.com>,
	"peterhuewe@gmx.de" <peterhuewe@gmx.de>,
	"jgg@ziepe.ca" <jgg@ziepe.ca>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-integrity@vger.kernel.org"
	<linux-integrity@vger.kernel.org>
Subject: Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled
Date: Wed, 20 Dec 2017 17:45:16 +0100	[thread overview]
Message-ID: <ba99c3c1-c3da-4045-a9d9-3801793db6b1@redhat.com> (raw)
In-Reply-To: <5FFFAD06ADE1CA4381B3F0F7C6AF58289887AA@ORSMSX109.amr.corp.intel.com>

Hello Azhar,

On 12/20/2017 04:41 PM, Shaikh, Azhar wrote:
> 
> 
>> -----Original Message-----
>> From: Javier Martinez Canillas [mailto:javierm@redhat.com]
>> Sent: Wednesday, December 20, 2017 7:31 AM
>> To: Shaikh, Azhar <azhar.shaikh@intel.com>;
>> Alexander.Steffen@infineon.com; hdegoede@redhat.com; linux-
>> kernel@vger.kernel.org
>> Cc: james@ettle.org.uk; arnd@arndb.de; jarkko.sakkinen@linux.intel.com;
>> peterhuewe@gmx.de; jgg@ziepe.ca; gregkh@linuxfoundation.org; linux-
>> integrity@vger.kernel.org
>> Subject: Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell
>> systems due CLKRUN enabled
>>
>> Hello Azhar,
>>
>> On 12/20/2017 04:08 PM, Shaikh, Azhar wrote:
>>
>> [snip]
>>
>>>>>
>>>>>> It seems that on machines with a PS/2 controller connected to the
>>>>>> LPC bus the BIOS is already doing this, so I've a feeling that it
>>>>>> not being done on devices with a TPM is a bug in the firmware
>>>>>
>>>>> Absolutely agree, system integratos should make sure that all the
>>>>> devices connected to the LPC either have CLKRUN protocol support and
>>>>> is enabled or disable the CLKRUN protocol permanently.
>>>>
>>>> As far as I understand it, this is exactly the issue here: They know
>>>> that there are devices that do not support the CLKRUN protocol (the
>>>> TPM in this case), but they still need to enable it to prevent other
>>>> issues. So for the TPM to continue to work, CLKRUN needs to be
>>>> disabled temporarily while the TPM is active.
>>>>
>>>
>>> Yes that was the reason to have this fix. We needed CLKRUN to be enabled
>> for Braswell SOC . But the TPM in this case SLB9655 does not support CLKRUN
>> (please check this public documentation
>> https://www.infineon.com/dgdl/Infineon-TPM+SLB+9665-DS-v10_15-
>> EN.pdf?fileId=5546d4625185e0e201518b83d9273d87 section 2.3 Power
>> Management). So as Alexander mentioned CLKRUN is disabled while TPM
>> transactions are in progress.
>>>
>>
>> Yes I do understand that. Please read my answer to Alexander's email and
>> also my question (and Hans') about keeping the CLKRUN protocol
>> permanently disabled.
>>
> 
> We had to enable CLKRUN for BSW issues as mentioned here https://www.intel.com/content/www/us/en/processors/pentium/pentium-celeron-n-series-spec-update.html  on Page 24 CHP 49 and Page 25 CHP 51
> 

Thanks for the pointer. But it's still not clear to me after reading the
mentioned erratas why the CLKRUN protocol must be enabled.

CHP49 says "System May Experience Inability to Boot or May Cease Operation"
and that it may be related to the LPC circuitry to stop functioning which
causes the inability to boot when activity is high for several years.

And that the workaround is:

"Firmware code changes for LPC and RTC circuitry and mitigations for SD Card
circuitry have been identified and may be implemented for this erratum."

Is this Firmware code changes to enable the CLKRUN protocol to minimize the
LPC bus activity and so prevent the LPC circuitry to stop functioning?

CHP51 says "LPC Clock Control Using the LPC_CLKRUN# May Not Behave As Expected"
and that the implication is that "The SoC may prevent a peripheral device from
successfully requesting the LPC clock".

So I would say that CLKRUN protocol should NOT be enabled instead since the
CLKRUN# signal is not reliable. Or what am I missing here?

Best regards,
-- 
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat

  reply	other threads:[~2017-12-20 16:45 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-20 11:35 Javier Martinez Canillas
2017-12-20 11:35 ` [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region Javier Martinez Canillas
2017-12-20 15:25   ` Shaikh, Azhar
2017-12-20 18:08   ` Jason Gunthorpe
2017-12-20 18:21     ` Javier Martinez Canillas
2017-12-20 18:54       ` Jason Gunthorpe
2017-12-20 19:15         ` Shaikh, Azhar
2017-12-21 12:48           ` Javier Martinez Canillas
2017-12-21 15:39             ` Shaikh, Azhar
2017-12-21 15:53               ` Javier Martinez Canillas
2017-12-21 16:34                 ` Shaikh, Azhar
2017-12-22 18:35   ` Jarkko Sakkinen
2017-12-24 20:57   ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 2/4] tpm: delete the TPM_TIS_CLK_ENABLE flag Javier Martinez Canillas
2017-12-20 15:19   ` Shaikh, Azhar
2017-12-20 18:10     ` Jason Gunthorpe
2017-12-20 18:26       ` Javier Martinez Canillas
2017-12-22 18:38         ` Jarkko Sakkinen
2017-12-22 18:33   ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 3/4] tpm: follow coding style for variable declaration in tpm_tis_core_init() Javier Martinez Canillas
2017-12-22 18:32   ` Jarkko Sakkinen
2017-12-20 11:35 ` [PATCH 4/4] tpm: only attempt to disable the LPC CLKRUN if is already enabled Javier Martinez Canillas
2017-12-22 18:36   ` Jarkko Sakkinen
2017-12-20 11:43 ` [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled Hans de Goede
2017-12-20 12:12   ` Javier Martinez Canillas
2017-12-20 14:07     ` Alexander.Steffen
2017-12-20 14:35       ` Javier Martinez Canillas
2017-12-20 15:08       ` Shaikh, Azhar
2017-12-20 15:31         ` Javier Martinez Canillas
2017-12-20 15:41           ` Shaikh, Azhar
2017-12-20 16:45             ` Javier Martinez Canillas [this message]
2017-12-20 17:44               ` Jason Gunthorpe
2017-12-20 18:33                 ` Javier Martinez Canillas
2017-12-22 18:39   ` Jarkko Sakkinen
2017-12-21 10:51 ` James Ettle
2017-12-21 12:46   ` Javier Martinez Canillas
2017-12-21 17:25     ` Jeffery Miller
2017-12-21 18:44       ` Javier Martinez Canillas
2017-12-21 19:02         ` Jeffery Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba99c3c1-c3da-4045-a9d9-3801793db6b1@redhat.com \
    --to=javierm@redhat.com \
    --cc=Alexander.Steffen@infineon.com \
    --cc=arnd@arndb.de \
    --cc=azhar.shaikh@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=james@ettle.org.uk \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®