* [PATCH v2] rv/reactor: add __init/__exit annotations to module init/exit funcs
@ 2022-09-06 14:12 Xiu Jianfeng
2022-09-06 17:34 ` Daniel Bristot de Oliveira
0 siblings, 1 reply; 2+ messages in thread
From: Xiu Jianfeng @ 2022-09-06 14:12 UTC (permalink / raw)
To: rostedt, mingo, bristot; +Cc: linux-kernel
Add missing __init/__exit annotations to module init/exit funcs.
Fixes: 135b881ea885 ("rv/reactor: Add the printk reactor")
Fixes: e88043c0ac16 ("rv/reactor: Add the panic reactor")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
kernel/trace/rv/reactor_panic.c | 4 ++--
kernel/trace/rv/reactor_printk.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/rv/reactor_panic.c b/kernel/trace/rv/reactor_panic.c
index b698d05dd069..d65f6c25a87c 100644
--- a/kernel/trace/rv/reactor_panic.c
+++ b/kernel/trace/rv/reactor_panic.c
@@ -24,13 +24,13 @@ static struct rv_reactor rv_panic = {
.react = rv_panic_reaction
};
-static int register_react_panic(void)
+static int __init register_react_panic(void)
{
rv_register_reactor(&rv_panic);
return 0;
}
-static void unregister_react_panic(void)
+static void __exit unregister_react_panic(void)
{
rv_unregister_reactor(&rv_panic);
}
diff --git a/kernel/trace/rv/reactor_printk.c b/kernel/trace/rv/reactor_printk.c
index 31899f953af4..4b6b7106a477 100644
--- a/kernel/trace/rv/reactor_printk.c
+++ b/kernel/trace/rv/reactor_printk.c
@@ -23,13 +23,13 @@ static struct rv_reactor rv_printk = {
.react = rv_printk_reaction
};
-static int register_react_printk(void)
+static int __init register_react_printk(void)
{
rv_register_reactor(&rv_printk);
return 0;
}
-static void unregister_react_printk(void)
+static void __exit unregister_react_printk(void)
{
rv_unregister_reactor(&rv_printk);
}
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] rv/reactor: add __init/__exit annotations to module init/exit funcs
2022-09-06 14:12 [PATCH v2] rv/reactor: add __init/__exit annotations to module init/exit funcs Xiu Jianfeng
@ 2022-09-06 17:34 ` Daniel Bristot de Oliveira
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Bristot de Oliveira @ 2022-09-06 17:34 UTC (permalink / raw)
To: Xiu Jianfeng, rostedt, mingo; +Cc: linux-kernel
On 9/6/22 16:12, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.
>
> Fixes: 135b881ea885 ("rv/reactor: Add the printk reactor")
> Fixes: e88043c0ac16 ("rv/reactor: Add the panic reactor")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Thanks!
-- Daniel
> ---
> kernel/trace/rv/reactor_panic.c | 4 ++--
> kernel/trace/rv/reactor_printk.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/trace/rv/reactor_panic.c b/kernel/trace/rv/reactor_panic.c
> index b698d05dd069..d65f6c25a87c 100644
> --- a/kernel/trace/rv/reactor_panic.c
> +++ b/kernel/trace/rv/reactor_panic.c
> @@ -24,13 +24,13 @@ static struct rv_reactor rv_panic = {
> .react = rv_panic_reaction
> };
>
> -static int register_react_panic(void)
> +static int __init register_react_panic(void)
> {
> rv_register_reactor(&rv_panic);
> return 0;
> }
>
> -static void unregister_react_panic(void)
> +static void __exit unregister_react_panic(void)
> {
> rv_unregister_reactor(&rv_panic);
> }
> diff --git a/kernel/trace/rv/reactor_printk.c b/kernel/trace/rv/reactor_printk.c
> index 31899f953af4..4b6b7106a477 100644
> --- a/kernel/trace/rv/reactor_printk.c
> +++ b/kernel/trace/rv/reactor_printk.c
> @@ -23,13 +23,13 @@ static struct rv_reactor rv_printk = {
> .react = rv_printk_reaction
> };
>
> -static int register_react_printk(void)
> +static int __init register_react_printk(void)
> {
> rv_register_reactor(&rv_printk);
> return 0;
> }
>
> -static void unregister_react_printk(void)
> +static void __exit unregister_react_printk(void)
> {
> rv_unregister_reactor(&rv_printk);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-06 17:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-06 14:12 [PATCH v2] rv/reactor: add __init/__exit annotations to module init/exit funcs Xiu Jianfeng
2022-09-06 17:34 ` Daniel Bristot de Oliveira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®