From: Paolo Bonzini <pbonzini@redhat.com>
To: "Christian Borntraeger" <borntraeger@de.ibm.com>,
"SF Markus Elfring" <elfring@users.sourceforge.net>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
"Cornelia Huck" <cornelia.huck@de.ibm.com>,
"Heiko Carstens" <heiko.carstens@de.ibm.com>,
"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: Move two error code assignments in kvm_vm_ioctl_get_dirty_log()
Date: Mon, 23 Jan 2017 10:19:56 +0100 [thread overview]
Message-ID: <5a595e1d-d59d-9289-2e9b-5bffb6fc6b12@redhat.com> (raw)
In-Reply-To: <35411200-2bd6-1c65-7d7f-21a6353875ea@de.ibm.com>
On 23/01/2017 09:22, Christian Borntraeger wrote:
> Patches that changes open coded things to common helpers or things like
> kmalloc_array where appropriate or things that make the code more robust
> are fine and welcome, but I am not going to take this as it just shuffles
> things around. It does not fix anything and it does not improve the code,
> but it certainly carries the risk of breaking something (yes in this case
> it looks perfectly fine, though).
Besides,
r = -ESOMETHING;
if (...)
return r;
is the way it's done everywhere else in KVM.
Paolo
next prev parent reply other threads:[~2017-01-23 9:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 16:03 SF Markus Elfring
2017-01-23 8:22 ` Christian Borntraeger
2017-01-23 9:19 ` Paolo Bonzini [this message]
2017-01-23 11:08 ` SF Markus Elfring
2017-01-23 11:58 ` Christian Borntraeger
2017-01-24 12:10 ` SF Markus Elfring
2017-01-24 12:18 ` Paolo Bonzini
2017-01-24 12:31 ` SF Markus Elfring
2017-01-24 12:38 ` Christian Borntraeger
2017-01-24 12:47 ` SF Markus Elfring
2017-01-23 12:21 ` Dan Carpenter
2017-01-23 13:21 ` SF Markus Elfring
2017-01-23 13:37 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a595e1d-d59d-9289-2e9b-5bffb6fc6b12@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=elfring@users.sourceforge.net \
--cc=heiko.carstens@de.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®