From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rosen Penev <rosenp@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] memory: fsl_ifc: Fix optional NAND IRQ handling and migrate to platform IRQ API
Date: Wed, 8 Jul 2026 13:02:04 +0200 [thread overview]
Message-ID: <5a63e6ff-fbd1-45d1-ad6f-8423c0f56e5e@kernel.org> (raw)
In-Reply-To: <20260604042856.90859-2-rosenp@gmail.com>
On 04/06/2026 06:28, Rosen Penev wrote:
> @@ -271,10 +265,16 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev)
> if (ret != 0) {
> dev_err(&dev->dev, "failed to install irq (%d)\n",
> fsl_ifc_ctrl_dev->irq);
> - goto err_unmap_nandirq;
> + goto err;
> }
>
> - if (fsl_ifc_ctrl_dev->nand_irq) {
> + /* get the nand machine irq */
> + fsl_ifc_ctrl_dev->nand_irq = platform_get_irq_optional(dev, 1);
> + if (fsl_ifc_ctrl_dev->nand_irq < 0) {
> + ret = fsl_ifc_ctrl_dev->nand_irq;
How did you test it? Looks like you change the logic and fail the probe
on missing IRQ.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-08 11:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 4:28 [PATCH 0/3] memory: fsl_ifc: Switch to modern devm and platform IRQ APIs Rosen Penev
2026-06-04 4:28 ` [PATCH 1/3] memory: fsl_ifc: Fix optional NAND IRQ handling and migrate to platform IRQ API Rosen Penev
2026-07-08 11:02 ` Krzysztof Kozlowski [this message]
2026-07-08 19:28 ` Rosen Penev
2026-06-04 4:28 ` [PATCH 2/3] memory: fsl_ifc: Use devm_platform_ioremap_resource and fix error paths Rosen Penev
2026-06-04 4:28 ` [PATCH 3/3] memory: fsl_ifc: Use devm_request_irq and simplify remove Rosen Penev
2026-07-08 11:04 ` Krzysztof Kozlowski
2026-07-08 19:37 ` Rosen Penev
2026-07-09 7:11 ` Krzysztof Kozlowski
2026-07-14 20:44 ` Rosen Penev
2026-07-15 4:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a63e6ff-fbd1-45d1-ad6f-8423c0f56e5e@kernel.org \
--to=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®