mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] memory: fsl_ifc: Use devm_request_irq and simplify remove
Date: Wed, 15 Jul 2026 06:34:57 +0200	[thread overview]
Message-ID: <6ca59291-7806-458d-9c47-66b2bf8bcc38@kernel.org> (raw)
In-Reply-To: <CAKxU2N8p3WM-GJ_AoQQz3q7OdAbXHVW-VCV8LVW=ADKrq0QrWQ@mail.gmail.com>

On 14/07/2026 22:44, Rosen Penev wrote:
> On Thu, Jul 9, 2026 at 12:11 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 08/07/2026 21:37, Rosen Penev wrote:
>>> On Wed, Jul 8, 2026 at 4:04 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>>
>>>> On 04/06/2026 06:28, Rosen Penev wrote:
>>>>> -
>>>>> -err_free_nandirq:
>>>>> -     if (fsl_ifc_ctrl_dev->nand_irq > 0)
>>>>> -             free_irq(fsl_ifc_ctrl_dev->nand_irq, fsl_ifc_ctrl_dev);
>>>>> -err_free_irq:
>>>>> -     free_irq(fsl_ifc_ctrl_dev->irq, fsl_ifc_ctrl_dev);
>>>>> -     return ret;
>>>>> +     return of_platform_default_populate(dev->dev.of_node, NULL, &dev->dev);
>>>>
>>>> This can be devm as well, in this patch.
>>> Not sure I follow.
>>
>> Use devm resource managed variant.
> What's the devm version of of_platform_default_populate?

Indeed, "default" variant does not have a devm. Patch is fine.

Best regards,
Krzysztof

      reply	other threads:[~2026-07-15  4:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04  4:28 [PATCH 0/3] memory: fsl_ifc: Switch to modern devm and platform IRQ APIs Rosen Penev
2026-06-04  4:28 ` [PATCH 1/3] memory: fsl_ifc: Fix optional NAND IRQ handling and migrate to platform IRQ API Rosen Penev
2026-07-08 11:02   ` Krzysztof Kozlowski
2026-07-08 19:28     ` Rosen Penev
2026-06-04  4:28 ` [PATCH 2/3] memory: fsl_ifc: Use devm_platform_ioremap_resource and fix error paths Rosen Penev
2026-06-04  4:28 ` [PATCH 3/3] memory: fsl_ifc: Use devm_request_irq and simplify remove Rosen Penev
2026-07-08 11:04   ` Krzysztof Kozlowski
2026-07-08 19:37     ` Rosen Penev
2026-07-09  7:11       ` Krzysztof Kozlowski
2026-07-14 20:44         ` Rosen Penev
2026-07-15  4:34           ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ca59291-7806-458d-9c47-66b2bf8bcc38@kernel.org \
    --to=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rosenp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox