* [PATCH] drm/sun4i: tcon: Delete an error message in sun4i_tcon_init_irq()
@ 2020-04-05 11:53 Markus Elfring
2020-04-06 8:19 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-04-05 11:53 UTC (permalink / raw)
To: dri-devel, linux-arm-kernel, Chen-Yu Tsai, Daniel Vetter,
David Airlie, Maxime Ripard
Cc: LKML, kernel-janitors, Tang Bin
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 5 Apr 2020 13:45:53 +0200
The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index 624437b27cdc..359b56e43b83 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -812,10 +812,8 @@ static int sun4i_tcon_init_irq(struct device *dev,
int irq, ret;
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(dev, "Couldn't retrieve the TCON interrupt\n");
+ if (irq < 0)
return irq;
- }
ret = devm_request_irq(dev, irq, sun4i_tcon_handler, 0,
dev_name(dev), tcon);
--
2.26.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/sun4i: tcon: Delete an error message in sun4i_tcon_init_irq()
2020-04-05 11:53 [PATCH] drm/sun4i: tcon: Delete an error message in sun4i_tcon_init_irq() Markus Elfring
@ 2020-04-06 8:19 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2020-04-06 8:19 UTC (permalink / raw)
To: Markus Elfring
Cc: dri-devel, linux-arm-kernel, Chen-Yu Tsai, Daniel Vetter,
David Airlie, LKML, kernel-janitors, Tang Bin
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Sun, Apr 05, 2020 at 01:53:05PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 5 Apr 2020 13:45:53 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied, thanks
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-06 8:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-05 11:53 [PATCH] drm/sun4i: tcon: Delete an error message in sun4i_tcon_init_irq() Markus Elfring
2020-04-06 8:19 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®