From: cruzzhao <cruzzhao@linux.alibaba.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: mingo@redhat.com, peterz@infradead.org, acme@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
kprateek.nayak@amd.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: ignore exited thread when synthesize thread map
Date: Tue, 28 Nov 2023 14:22:47 +0800 [thread overview]
Message-ID: <5ab76c0c-6333-4452-ae51-9193926c802c@linux.alibaba.com> (raw)
In-Reply-To: <CAM9d7chVZRKUSmXmZS4OyokKfLKp4h8K8RLWehYRpAs5Z4jsbg@mail.gmail.com>
在 2023/11/23 上午5:05, Namhyung Kim 写道:
> Hello,
>
> On Tue, Nov 21, 2023 at 6:22 PM Cruz Zhao <CruzZhao@linux.alibaba.com> wrote:
>>
>> When synthesize thread map, some threads in thread map may have
>> already exited, so that __event__synthesize_thread() returns -1
>> and the synthesis breaks. However, It will not have any effect
>> if we just ignore the exited thread. So just ignore it and continue.
>
> Looks ok. But I guess you want to do the same for the leader
> thread below as well.
>
> Thanks,
> Namhyung
>
With my testcase, no error is returned even if we don't do the same for
the leader thread blow. Well, I'll check whether the logic is still
correct if we do so.
Many thanks for reviewing.
Best,
Cruz Zhao
next prev parent reply other threads:[~2023-11-28 6:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 2:21 Cruz Zhao
2023-11-22 21:05 ` Namhyung Kim
2023-11-28 6:22 ` cruzzhao [this message]
2023-11-28 17:12 ` Ian Rogers
2023-12-05 17:54 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ab76c0c-6333-4452-ae51-9193926c802c@linux.alibaba.com \
--to=cruzzhao@linux.alibaba.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®