mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] gpio: ftgpio010: Fix platform_get_irq's error checking
@ 2017-12-02 17:01 Arvind Yadav
  2017-12-02 20:25 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-12-02 17:01 UTC (permalink / raw)
  To: linus.walleij; +Cc: linux-kernel, linux-gpio

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2:
             It's should be 'irq <= 0' instead of 'irq < 0'.

 drivers/gpio/gpio-ftgpio010.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
index 139f73d..fbb12f6 100644
--- a/drivers/gpio/gpio-ftgpio010.c
+++ b/drivers/gpio/gpio-ftgpio010.c
@@ -176,8 +176,8 @@ static int ftgpio_gpio_probe(struct platform_device *pdev)
 		return PTR_ERR(g->base);
 
 	irq = platform_get_irq(pdev, 0);
-	if (!irq)
-		return -EINVAL;
+	if (irq <= 0)
+		return irq ? irq : -EINVAL;
 
 	ret = bgpio_init(&g->gc, dev, 4,
 			 g->base + GPIO_DATA_IN,
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] gpio: ftgpio010: Fix platform_get_irq's error checking
  2017-12-02 17:01 [PATCH v2] gpio: ftgpio010: Fix platform_get_irq's error checking Arvind Yadav
@ 2017-12-02 20:25 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2017-12-02 20:25 UTC (permalink / raw)
  To: Arvind Yadav; +Cc: linux-kernel, linux-gpio

On Sat, Dec 2, 2017 at 6:01 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2:
>              It's should be 'irq <= 0' instead of 'irq < 0'.

Yep that's the right patch! Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-02 20:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-02 17:01 [PATCH v2] gpio: ftgpio010: Fix platform_get_irq's error checking Arvind Yadav
2017-12-02 20:25 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®