Re: [PATCH v16 1/5] phy: core: Fix use-after-free in phy_get paths

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/09/2026 15:55, Frank Li wrote:
> On Mon, Sep 14, 2026 at 12:37:06PM +0100, Bryan O'Donoghue wrote:
>> On 11/09/2026 21:56, Frank Li wrote:
>>> suggested subject:
>>>
>>> phy: core: use phy_provider_mutex protect between _of_phy_get and try_module_get()
>>
>> A pattern I try to encourage and role-model is making fixes very explicit
>> and obvious - frequently I'll ask people to prefix their patches fixing
>> things with Fix.
> 
> Generally, I got feedback from most maintainer is
> 
> 	do something to fix ...

You got it wrong, I think.

> 
> "do something" become more important. the most maintaniner dont like simple
> said

"Do something" is not more important, because you repeat the diff.

> 	- fix build warning
> 	- simplify code
> 	- fix UAF
> 	- fix memory leask
> 

Exactly all above are "do something"...

> I think it is reasonable, git log --oneline ..., if just list
> 	"fix build warning", which is hard to locate patch because there
> are too much "fix build warning".

And "rename function to fix build warning" is not better, because rename
is obvious from the diff. Title should not say what you are doing, but
explain the nature of the bug being fixed, so "fix build warning due to
typo in foo bar" would be better.

Best regards,
Krzysztof