From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Frank Li <Frank.li@oss.nxp.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Bryan O'Donoghue <bod@kernel.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Felipe Balbi <balbi@ti.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-phy@lists.infradead.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v16 3/5] phy: core: Add devm_phy_get_by_of_node()
Date: Mon, 14 Sep 2026 12:03:11 +0100 [thread overview]
Message-ID: <ceca8547-ff15-4f5a-8844-8ec9061a5e6c@linaro.org> (raw)
In-Reply-To: <aqRuCfmgPqa5h0y4@lizhi-Precision-Tower-5810>
On 11/09/2026 22:09, Frank Li wrote:
>> + if (!link)
>> + dev_dbg(dev, "failed to create device link to %s\n",
>> + dev_name(phy->dev.parent));
> Is it okay to print dbg message()? suppose return NULL or some error?
This should be dev_err() for sure thx
---
bod
next prev parent reply other threads:[~2026-09-14 11:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 11:52 [PATCH v16 0/5] Add phy_get_by_of_node and devm helper Bryan O'Donoghue
2026-09-06 11:52 ` [PATCH v16 1/5] phy: core: Fix use-after-free in phy_get paths Bryan O'Donoghue
2026-09-11 20:56 ` Frank Li
2026-09-14 11:37 ` Bryan O'Donoghue
2026-09-14 13:55 ` Frank Li
2026-09-14 15:49 ` Krzysztof Kozlowski
2026-09-06 11:52 ` [PATCH v16 2/5] phy: core: Add phy_get_by_of_node() Bryan O'Donoghue
2026-09-06 11:52 ` [PATCH v16 3/5] phy: core: Add devm_phy_get_by_of_node() Bryan O'Donoghue
2026-09-11 21:09 ` Frank Li
2026-09-14 11:03 ` Bryan O'Donoghue [this message]
2026-09-06 11:52 ` [PATCH v16 4/5] media: qcom: camss: Add support for PHY API devices Bryan O'Donoghue
2026-09-06 11:52 ` [PATCH v16 5/5] media: qcom: camss: Use data-lanes starting at 1 for new CSIPHY mode Bryan O'Donoghue
2026-09-06 13:03 ` Nihal Kumar Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceca8547-ff15-4f5a-8844-8ec9061a5e6c@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=Frank.li@oss.nxp.com \
--cc=andersson@kernel.org \
--cc=balbi@ti.com \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=todor.too@gmail.com \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®