mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net-next] net: phy: update obsolete comment about PHY_STARTING
@ 2023-02-21 10:57 Wolfram Sang
  2023-02-21 11:11 ` Heiner Kallweit
  2023-02-21 12:17 ` Paolo Abeni
  0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2023-02-21 10:57 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Andrew Lunn, Heiner Kallweit, Russell King,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	netdev, linux-kernel

Commit 899a3cbbf77a ("net: phy: remove states PHY_STARTING and
PHY_PENDING") missed to update a comment in phy_probe. Remove
superfluous "Description:" prefix while we are here.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/net/phy/phy_device.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 8cff61dbc4b5..3a515955ffd8 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -3019,9 +3019,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_phy_node);
  * phy_probe - probe and init a PHY device
  * @dev: device to probe and init
  *
- * Description: Take care of setting up the phy_device structure,
- *   set the state to READY (the driver's init function should
- *   set it to STARTING if needed).
+ * Take care of setting up the phy_device structure, set the state to READY.
  */
 static int phy_probe(struct device *dev)
 {
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: phy: update obsolete comment about PHY_STARTING
  2023-02-21 10:57 [PATCH net-next] net: phy: update obsolete comment about PHY_STARTING Wolfram Sang
@ 2023-02-21 11:11 ` Heiner Kallweit
  2023-02-21 12:17 ` Paolo Abeni
  1 sibling, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2023-02-21 11:11 UTC (permalink / raw)
  To: Wolfram Sang, linux-renesas-soc
  Cc: Andrew Lunn, Russell King, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, netdev, linux-kernel

On 21.02.2023 11:57, Wolfram Sang wrote:
> Commit 899a3cbbf77a ("net: phy: remove states PHY_STARTING and
> PHY_PENDING") missed to update a comment in phy_probe. Remove
> superfluous "Description:" prefix while we are here.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/net/phy/phy_device.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 8cff61dbc4b5..3a515955ffd8 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -3019,9 +3019,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_phy_node);
>   * phy_probe - probe and init a PHY device
>   * @dev: device to probe and init
>   *
> - * Description: Take care of setting up the phy_device structure,
> - *   set the state to READY (the driver's init function should
> - *   set it to STARTING if needed).
> + * Take care of setting up the phy_device structure, set the state to READY.
>   */
>  static int phy_probe(struct device *dev)
>  {

Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: phy: update obsolete comment about PHY_STARTING
  2023-02-21 10:57 [PATCH net-next] net: phy: update obsolete comment about PHY_STARTING Wolfram Sang
  2023-02-21 11:11 ` Heiner Kallweit
@ 2023-02-21 12:17 ` Paolo Abeni
  1 sibling, 0 replies; 3+ messages in thread
From: Paolo Abeni @ 2023-02-21 12:17 UTC (permalink / raw)
  To: Wolfram Sang, linux-renesas-soc
  Cc: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
	Eric Dumazet, Jakub Kicinski, netdev, linux-kernel

On Tue, 2023-02-21 at 11:57 +0100, Wolfram Sang wrote:
> Commit 899a3cbbf77a ("net: phy: remove states PHY_STARTING and
> PHY_PENDING") missed to update a comment in phy_probe. Remove
> superfluous "Description:" prefix while we are here.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

# Form letter - net-next is closed

The merge window for v6.3 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after Mar 6th.

RFC patches sent for review only are obviously welcome at any time.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-02-21 12:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-21 10:57 [PATCH net-next] net: phy: update obsolete comment about PHY_STARTING Wolfram Sang
2023-02-21 11:11 ` Heiner Kallweit
2023-02-21 12:17 ` Paolo Abeni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®