From: Andrew Lunn <andrew@lunn.ch>
To: Kenny Ho <y2kenny@gmail.com>
Cc: Marc Dionne <marc.dionne@auristor.com>,
Kenny Ho <Kenny.Ho@amd.com>, David Howells <dhowells@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-afs@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove hardcoded static string length
Date: Wed, 24 May 2023 19:43:11 +0200 [thread overview]
Message-ID: <5b1355b8-17f7-49c8-b7b5-3d9ecdb146ce@lunn.ch> (raw)
In-Reply-To: <CAOWid-erNGD24Ouf4fAJJBqm69QVoHOpNt0E-G+Wt=nq1W4oBQ@mail.gmail.com>
On Wed, May 24, 2023 at 01:02:36PM -0400, Kenny Ho wrote:
> On Wed, May 24, 2023 at 12:02 PM Andrew Lunn <andrew@lunn.ch> wrote:
> > So the compiler warning/error needs to be fixed a different want.
>
> Understood. Would caping the length at iov_len with a ternary be sufficient?
The quoted text said 'string'. It is not clear if that means c-string,
with a trailing \0. If you just cap iov_len you could end up with a
string which is not terminated.
The other end of the socket should not blow up, because that would be
an obvious DOS or buffer overwrite attack vector. So you need to
decide, do you want to expose such issues and see if anything does
actually blow up, or do you want to do a bit more work and correctly
terminate the string when capped?
Andrew
next prev parent reply other threads:[~2023-05-24 17:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 22:39 Kenny Ho
2023-05-24 0:49 ` Andrew Lunn
2023-05-24 15:43 ` Marc Dionne
2023-05-24 16:01 ` Andrew Lunn
2023-05-24 17:02 ` Kenny Ho
2023-05-24 17:43 ` Andrew Lunn [this message]
2023-05-24 18:01 ` Kenny Ho
2023-05-25 9:14 ` David Laight
2023-05-25 14:27 ` Kenny Ho
2023-05-25 15:04 ` David Laight
2023-05-25 15:37 ` Kenny Ho
2023-05-27 15:08 ` Jeffrey E Altman
2023-05-29 13:32 ` David Laight
2023-05-30 14:39 ` Jeffrey E Altman
2023-05-27 14:45 ` Jeffrey E Altman
2023-05-27 15:08 ` Jeffrey E Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b1355b8-17f7-49c8-b7b5-3d9ecdb146ce@lunn.ch \
--to=andrew@lunn.ch \
--cc=Kenny.Ho@amd.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=y2kenny@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®