mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>, linux-kernel@vger.kernel.org
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	linux-scsi@vger.kernel.org,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: ufs: clean up the Kconfig file
Date: Sun, 24 Oct 2021 16:35:43 -0700	[thread overview]
Message-ID: <5b13f32c-0cdb-26de-2bb7-af56a099b0b2@infradead.org> (raw)
In-Reply-To: <8578e393-2a25-bc52-65ea-599d071387e9@acm.org>

On 10/24/21 2:29 PM, Bart Van Assche wrote:
> On 10/23/21 23:43, Randy Dunlap wrote:
>> @@ -39,7 +38,7 @@ config SCSI_UFSHCD
>>       select DEVFREQ_GOV_SIMPLE_ONDEMAND
>>       select NLS
>>       help
>> -      This selects the support for UFS devices in Linux, say Y and make
>> +      This selects the support for UFS devices in Linux. Say Y and make
> 
> How about changing "This selects the support for UFS devices in Linux"
> into "Enables support for UFS devices"? "the" should be left out from a
> grammatical point of view and "in Linux" is redundant.

OK, done (locally).

>>         sure that you know the name of your UFS host adapter (the card
>>         inside your computer that "speaks" the UFS protocol, also
>>         called UFS Host Controller), because you will be asked for it.
>> @@ -51,7 +50,7 @@ config SCSI_UFSHCD
>>         (the one containing the directory /) is located on a UFS device.
>>   config SCSI_UFSHCD_PCI
>> -    tristate "PCI bus based UFS Controller support"
>> +    tristate "PCI bus-based UFS Controller support"
> 
> Even with this change applied capitalization is inconsistent.

I don't doubt it, but could you be more explicit about
which word(s) you mean, please?

I see one "pci" in the Kconfig file.
I see several "Controller" vs. "controller."
I see a few of "Support" vs. "support."

Which are you referring to? (or something else)

thanks.
-- 
~Randy

  reply	other threads:[~2021-10-24 23:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-24  6:43 Randy Dunlap
2021-10-24 21:29 ` Bart Van Assche
2021-10-24 23:35   ` Randy Dunlap [this message]
2021-10-25  1:17     ` Bart Van Assche
2021-10-26  5:23       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b13f32c-0cdb-26de-2bb7-af56a099b0b2@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®