Re: [PATCH net-next v7 1/5] net: phy: mediatek: Re-organize MediaTek ethernet phy drivers

["SkyLake Huang (黃啟澤)" <SkyLake.Huang@mediatek.com>]

On Wed, 2024-06-19 at 09:31 +0100, Russell King (Oracle) wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Thu, Jun 13, 2024 at 06:40:19PM +0800, Sky Huang wrote:
> > diff --git a/drivers/net/phy/mediatek-ge-soc.c
> b/drivers/net/phy/mediatek/mtk-ge-soc.c
> > similarity index 99%
> > rename from drivers/net/phy/mediatek-ge-soc.c
> > rename to drivers/net/phy/mediatek/mtk-ge-soc.c
> > index f4f9412..47af872 100644
> > --- a/drivers/net/phy/mediatek-ge-soc.c
> > +++ b/drivers/net/phy/mediatek/mtk-ge-soc.c
> > @@ -1415,7 +1415,7 @@ static int mt7988_phy_probe_shared(struct
> phy_device *phydev)
> >   * LED_C and LED_D respectively. At the same time those pins are
> used to
> >   * bootstrap configuration of the reference clock source (LED_A),
> >   * DRAM DDRx16b x2/x1 (LED_B) and boot device (LED_C, LED_D).
> > - * In practise this is done using a LED and a resistor pulling the
> pin
> > + * In practice this is done using a LED and a resistor pulling the
> pin
> 
> If you are moving files around, there should be no extraneous changes
> in the commit that is doing the move. This is a spelling fix, and
> that
> should be a separate patch (and probably should be done as the first
> patch.)
> 
> Thanks.
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

I'll create another patch in next version. Thanks.

BRs,
Sky