From: "SkyLake Huang (黃啟澤)" <SkyLake.Huang@mediatek.com>
To: "kuba@kernel.org" <kuba@kernel.org>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"dqfext@gmail.com" <dqfext@gmail.com>,
"Steven Liu (劉人豪)" <steven.liu@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"daniel@makrotopia.org" <daniel@makrotopia.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH net-next v7 2/5] net: phy: mediatek: Move LED and read/write page helper functions into mtk phy lib
Date: Wed, 19 Jun 2024 08:17:56 +0000 [thread overview]
Message-ID: <680c25911c9a564960a371870bdaf59aa9d3b991.camel@mediatek.com> (raw)
In-Reply-To: <20240618082111.27d386b6@kernel.org>
On Tue, 2024-06-18 at 08:21 -0700, Jakub Kicinski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On Thu, 13 Jun 2024 18:40:20 +0800 Sky Huang wrote:
> > This patch moves mtk-ge-soc.c's LED code into mtk phy lib. We
> > can use those helper functions in mtk-ge.c as well. That is to
> > say, we have almost the same HW LED controller design in
> > mt7530/mt7531/mt7981/mt7988's Giga ethernet phy.
> >
> > Also integrate read/write pages into one helper function. They
> > are basically the same.
>
> Could you please split this into multiple patches? maybe:
> - change the line wrapping
> - integrate read/write pages into one helper
> - create mtk-phy-lib.c and mtk.h (pure code move)
> - add support for LEDs to the other SoC
Hi Jakub,
Mmm...Sorry. But is this really necessary? I already did similar
things in v2. IMHO, current patchset is small enough for reviewing. You
can easily tell that which parts come from original mediatek-ge.c &
mediatek-ge-soc.c and which part is used for MT7988's mtk-2p5ge.c
BRs,
Sky
next prev parent reply other threads:[~2024-06-19 8:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 10:40 [PATCH net-next v7 0/5] net: phy: mediatek: Introduce mtk-phy-lib and add 2.5Gphy support Sky Huang
2024-06-13 10:40 ` [PATCH net-next v7 1/5] net: phy: mediatek: Re-organize MediaTek ethernet phy drivers Sky Huang
2024-06-19 8:31 ` Russell King (Oracle)
2024-06-19 9:14 ` SkyLake Huang (黃啟澤)
2024-06-13 10:40 ` [PATCH net-next v7 2/5] net: phy: mediatek: Move LED and read/write page helper functions into mtk phy lib Sky Huang
2024-06-17 11:51 ` Simon Horman
2024-06-19 8:13 ` SkyLake Huang (黃啟澤)
2024-06-18 15:21 ` Jakub Kicinski
2024-06-19 8:17 ` SkyLake Huang (黃啟澤) [this message]
2024-06-19 10:37 ` SkyLake Huang (黃啟澤)
2024-06-19 8:58 ` Russell King (Oracle)
2024-06-19 11:21 ` SkyLake Huang (黃啟澤)
2024-06-13 10:40 ` [PATCH net-next v7 3/5] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib Sky Huang
2024-06-19 9:01 ` Russell King (Oracle)
2024-06-19 11:33 ` SkyLake Huang (黃啟澤)
2024-06-13 10:40 ` [PATCH net-next v7 4/5] net: phy: mediatek: Extend 1G TX/RX link pulse time Sky Huang
2024-06-13 10:40 ` [PATCH net-next v7 5/5] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988 Sky Huang
2024-06-19 9:09 ` Russell King (Oracle)
2024-06-19 11:44 ` SkyLake Huang (黃啟澤)
2024-06-19 20:09 ` Russell King (Oracle)
2024-06-20 4:32 ` SkyLake Huang (黃啟澤)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=680c25911c9a564960a371870bdaf59aa9d3b991.camel@mediatek.com \
--to=skylake.huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steven.liu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®