From: "Bean Huo (beanhuo)" <beanhuo@micron.com>
To: Bart Van Assche <bart.vanassche@wdc.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"rajatja@google.com" <rajatja@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"mingo@redhad.com" <mingo@redhad.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>
Subject: Re: [RESEND PATCH v1 1/2] trace: events: scsi: Add tag in SCSI trace events
Date: Mon, 16 Apr 2018 20:27:13 +0000 [thread overview]
Message-ID: <5b2fdd1b29b54590889194eba90debfb@SIWEX5A.sing.micron.com> (raw)
>>> This patch is not acceptable because it adds support for tag tracing
>>> to the legacy block layer only. Any patch that adds a new feature to
>>> the legacy block layer must also add it to blk-mq.
>>>
>> To be honest, I don't understand your point, can you give me more
>explanation?
>
>The legacy block layer will be removed as soon as blk-mq provides all the
>functionality of the legacy block layer and as soon as it performs at least as
>well as the legacy block layer for all use cases. If new features are added to
>the legacy block layer but not to blk-mq that prevents removal of the legacy
>block layer. Hence the requirement I explained in my previous e-mail.
>
>Bart.
Thanks for your information.
I have several questions again.
When the legacy block layer will be replaced by blk-mq?
And "include/trece/event/block.h .. scsi.h" will also be changed?
Do you have the related git rep or mail list about this topic?
Maybe this is great big change, I am very interested in that. And want to have a look at.
By the way, these patches are not to add new feature, they are just to add print tag along with the other exist
Printed request parameters. The blk-mq is now still using "include/trace/evet/block.h" defined trace events.
For example:
void blk_mq_start_request(struct request *rq)
{
...
...
trace_block_rq_issue(q, rq);
...
...
}
Do you mean that this will also be removed/replaced by someone else?
Bean Huo
next reply other threads:[~2018-04-16 20:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 20:27 Bean Huo (beanhuo) [this message]
2018-04-16 20:43 ` Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2018-04-17 12:09 Bean Huo (beanhuo)
2018-04-17 10:00 Bean Huo (beanhuo)
2018-04-23 12:58 ` Steffen Maier
2018-04-16 21:10 Bean Huo (beanhuo)
2018-04-16 21:20 ` Bart Van Assche
2018-04-16 17:05 Bean Huo (beanhuo)
2018-04-16 17:11 ` Bart Van Assche
2018-04-16 14:31 Bean Huo (beanhuo)
2018-04-16 15:28 ` Steven Rostedt
2018-04-16 16:41 ` Rajat Jain
2018-04-16 16:47 ` Bart Van Assche
2018-04-16 20:49 ` Bart Van Assche
2018-04-16 21:24 ` Steven Rostedt
2018-04-16 21:30 ` Bart Van Assche
2018-04-16 22:06 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b2fdd1b29b54590889194eba90debfb@SIWEX5A.sing.micron.com \
--to=beanhuo@micron.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mingo@redhad.com \
--cc=rajatja@google.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®