Re: [PATCH] arm64: dts: qcom: hamoa-iot-evk: Enable display support

[Yongxing Mou <quic_yongmou@quicinc.com>]

On 2025/7/23 19:38, Konrad Dybcio wrote:
> On 7/23/25 8:14 AM, Yongxing Mou wrote:
>> Enable DisplayPort support on all three USB-C ports of the
>> hamoa-iot-evk platform.
>>
>> Unlike most X1E-based boards, this platform uses FSUSB42 USB
>> switches for the USB0 Type-C port, while USB1 and USB2 rely on
>> Parade PS8830 retimers for Alt Mode switching.
>>
>> Support for the PS8830 retimers was already included in the
>> initial DTS, so this change adds support for the FSUSB42 switches.
>>
>> Due to limitations in the USB/DP combo PHY driver, DisplayPort
>> functionality is limited to 2 lanes instead of the maximum 4,
>> consistent with other X1E-based platforms.
>>
>> The platform also supports embedded DisplayPort (eDP) by default.
>>
>> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
>> ---
>> This change made top of initial DTS:
>> https://lore.kernel.org/all/20250716-hamoa_initial-v1-0-f6f5d0f9a163@oss.qualcomm.com/
>> ---
> 
> [...]
> 
>> +	ports {
>> +		port@1 {
>> +			reg = <1>;
>> +			mdss_dp3_out: endpoint {
> 
> Please keep a \n between properties and subnodes
> 
Okay. will update next patch.
> [...]
> 
>> base-commit: 0be23810e32e6d0a17df7c0ebad895ba2c210fc4
>> change-id: 20250721-x1e-evk-dp-141e0df5593d
>> prerequisite-message-id: <20250716-hamoa_initial-v1-0-f6f5d0f9a163@oss.qualcomm.com>
>> prerequisite-patch-id: 3c553b55d143eafc1036ce2e88df558ec61c4e83
>> prerequisite-patch-id: a4b2dabd376d32ecb159141c17113a8f3fc4ddfa
>> prerequisite-patch-id: 24bf2ada12dc10f9980ed2c56347e5b6f7964ebd
>> prerequisite-patch-id: c764e86c94055e56aaf9e701341bba52a54a998b
> 
> Having so many dependencies should raise your attention..
> 
> Konrad
Okay, will merge into initial DTS, and this will remove dependencies.