mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: "Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Javier González" <javier@cnexlabs.com>,
	"Matias Bjørling" <matias@cnexlabs.com>,
	"Keith Busch" <keith.busch@intel.com>,
	"Christoph Hellwig" <hch@lst.de>,
	"Sagi Grimberg" <sagi@grimberg.me>
Cc: <linux-nvme@lists.infradead.org>, Arnd Bergmann <arnd@arndb.de>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lightnvm: remove unused rq parameter of nvme_nvm_rqtocmd() to kill warning
Date: Sun, 7 May 2017 19:53:33 -0600	[thread overview]
Message-ID: <5bc0bd5f-4eb5-5975-4700-071b78047917@fb.com> (raw)
In-Reply-To: <1494166484-11363-1-git-send-email-geert@linux-m68k.org>

On 05/07/2017 08:14 AM, Geert Uytterhoeven wrote:
> With gcc 4.1.2:

Wow, that's ancient.

>     drivers/nvme/host/lightnvm.c: In function ‘nvme_nvm_submit_io’:
>     drivers/nvme/host/lightnvm.c:498: warning: ‘rq’ is used uninitialized in this function
> 
> Indeed, since commit 2e13f33a2464fc3a ("lightnvm: create cmd before
> allocating request"), the request is passed to nvme_nvm_rqtocmd() before
> it is allocated.
> 
> Fortunately, as of commit 91276162de9476b8 ("lightnvm: refactor end_io
> functions for sync"), nvme_nvm_rqtocmd () no longer uses the passed
> request, so this warning is a false positive.
> 
> Drop the unused parameter to clean up the code and kill the warning.

Thanks, applied.

-- 
Jens Axboe

  reply	other threads:[~2017-05-08  1:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-07 14:14 Geert Uytterhoeven
2017-05-08  1:53 ` Jens Axboe [this message]
2017-05-08  7:25   ` Geert Uytterhoeven
2017-05-08  7:51     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bc0bd5f-4eb5-5975-4700-071b78047917@fb.com \
    --to=axboe@fb.com \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=hch@lst.de \
    --cc=javier@cnexlabs.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=matias@cnexlabs.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®