From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Kamil Horák - 2N" <kamilh@axis.com>,
bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, f.fainelli@gmail.com,
robh@kernel.org, andrew+netdev@lunn.ch
Subject: Re: [PATCH net v4 4/4] net: phy: bcm54811: Fix the PHY initialization
Date: Mon, 30 Jun 2025 10:07:30 -0700 [thread overview]
Message-ID: <5c011ec0-67e1-4c9b-8ea6-e098b16f0f45@broadcom.com> (raw)
In-Reply-To: <20250630135837.1173063-5-kamilh@axis.com>
On 6/30/25 06:58, Kamil Horák - 2N wrote:
> Reset the bit 12 in PHY's LRE Control register upon initialization.
> According to the datasheet, this bit must be written to zero after
> every device reset.
>
> Fixes: 03ab6c244bb0 ("net: phy: bcm-phy-lib: Implement BroadR-Reach link modes")
> Signed-off-by: Kamil Horák - 2N <kamilh@axis.com>
> ---
[snip]
> diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h
> index 15c35655f482..115a964f3006 100644
> --- a/include/linux/brcmphy.h
> +++ b/include/linux/brcmphy.h
> @@ -137,6 +137,7 @@
>
> #define MII_BCM54XX_AUXCTL_SHDWSEL_MISC 0x07
> #define MII_BCM54XX_AUXCTL_SHDWSEL_MISC_WIRESPEED_EN 0x0010
> +#define MII_BCM54XX_AUXCTL_SHDWSEL_MISC_RSVD 0x0060
> #define MII_BCM54XX_AUXCTL_SHDWSEL_MISC_RGMII_EN 0x0080
> #define MII_BCM54XX_AUXCTL_SHDWSEL_MISC_RGMII_SKEW_EN 0x0100
> #define MII_BCM54XX_AUXCTL_MISC_FORCE_AMDIX 0x0200
This register is not used in this patch or previous ones, please drop
it, with that:
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2025-06-30 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 13:58 [PATCH net v4 0/4] " Kamil Horák - 2N
2025-06-30 13:58 ` [PATCH net v4 1/4] net: phy: MII-Lite PHY interface mode Kamil Horák - 2N
2025-06-30 17:06 ` Florian Fainelli
2025-06-30 13:58 ` [PATCH net v4 2/4] dt-bindings: ethernet-phy: add MII-Lite phy interface type Kamil Horák - 2N
2025-06-30 17:06 ` Florian Fainelli
2025-06-30 13:58 ` [PATCH net v4 3/4] net: phy: bcm5481x: MII-Lite activation Kamil Horák - 2N
2025-06-30 17:06 ` Florian Fainelli
2025-06-30 13:58 ` [PATCH net v4 4/4] net: phy: bcm54811: Fix the PHY initialization Kamil Horák - 2N
2025-06-30 17:07 ` Florian Fainelli [this message]
2025-06-30 17:06 ` [PATCH net v4 0/4] " Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c011ec0-67e1-4c9b-8ea6-e098b16f0f45@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kamilh@axis.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®