From: neil.armstrong@linaro.org
To: Cong Yang <yangcong5@huaqin.corp-partner.google.com>,
sam@ravnborg.org, daniel@ffwll.ch, airlied@gmail.com,
dianders@google.com, hsinyi@google.com
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: Fine tune Starry-ili9882t panel HFP and HBP
Date: Mon, 26 Jun 2023 15:38:27 +0200 [thread overview]
Message-ID: <5c3bcc62-28ba-e88f-6a19-4f620489284a@linaro.org> (raw)
In-Reply-To: <20230626120724.161117-1-yangcong5@huaqin.corp-partner.google.com>
Hi,
On 26/06/2023 14:07, Cong Yang wrote:
> Because the setting of hproch is too small, there will be warning in
> kernel log[1]. After fine tune the HFP and HBP, this warning can be
> solved. The actual measurement frame rate is 60.1Hz.
>
> [1]: WARNING kernel:[drm] HFP + HBP less than d-phy, FPS will under 60Hz
>
> Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
> ---
> drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index 3cc9fb0d4f5d..dc276c346fd1 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -2139,9 +2139,9 @@ static const struct panel_desc starry_himax83102_j02_desc = {
> static const struct drm_display_mode starry_ili9882t_default_mode = {
> .clock = 165280,
> .hdisplay = 1200,
> - .hsync_start = 1200 + 32,
> - .hsync_end = 1200 + 32 + 30,
> - .htotal = 1200 + 32 + 30 + 32,
> + .hsync_start = 1200 + 72,
> + .hsync_end = 1200 + 72 + 30,
> + .htotal = 1200 + 72 + 30 + 72,
> .vdisplay = 1920,
> .vsync_start = 1920 + 68,
> .vsync_end = 1920 + 68 + 2,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
but can you resend with a appropriate Fixes tag ?
thanks,
Neil
prev parent reply other threads:[~2023-06-26 13:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 12:07 Cong Yang
2023-06-26 13:38 ` neil.armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c3bcc62-28ba-e88f-6a19-4f620489284a@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®