* [PATCH] drm/panel: Fine tune Starry-ili9882t panel HFP and HBP
@ 2023-06-26 12:07 Cong Yang
2023-06-26 13:38 ` neil.armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Cong Yang @ 2023-06-26 12:07 UTC (permalink / raw)
To: sam, neil.armstrong, daniel, airlied, dianders, hsinyi
Cc: dri-devel, devicetree, linux-kernel, Cong Yang
Because the setting of hproch is too small, there will be warning in
kernel log[1]. After fine tune the HFP and HBP, this warning can be
solved. The actual measurement frame rate is 60.1Hz.
[1]: WARNING kernel:[drm] HFP + HBP less than d-phy, FPS will under 60Hz
Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
---
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
index 3cc9fb0d4f5d..dc276c346fd1 100644
--- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
+++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
@@ -2139,9 +2139,9 @@ static const struct panel_desc starry_himax83102_j02_desc = {
static const struct drm_display_mode starry_ili9882t_default_mode = {
.clock = 165280,
.hdisplay = 1200,
- .hsync_start = 1200 + 32,
- .hsync_end = 1200 + 32 + 30,
- .htotal = 1200 + 32 + 30 + 32,
+ .hsync_start = 1200 + 72,
+ .hsync_end = 1200 + 72 + 30,
+ .htotal = 1200 + 72 + 30 + 72,
.vdisplay = 1920,
.vsync_start = 1920 + 68,
.vsync_end = 1920 + 68 + 2,
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/panel: Fine tune Starry-ili9882t panel HFP and HBP
2023-06-26 12:07 [PATCH] drm/panel: Fine tune Starry-ili9882t panel HFP and HBP Cong Yang
@ 2023-06-26 13:38 ` neil.armstrong
0 siblings, 0 replies; 2+ messages in thread
From: neil.armstrong @ 2023-06-26 13:38 UTC (permalink / raw)
To: Cong Yang, sam, daniel, airlied, dianders, hsinyi
Cc: dri-devel, devicetree, linux-kernel
Hi,
On 26/06/2023 14:07, Cong Yang wrote:
> Because the setting of hproch is too small, there will be warning in
> kernel log[1]. After fine tune the HFP and HBP, this warning can be
> solved. The actual measurement frame rate is 60.1Hz.
>
> [1]: WARNING kernel:[drm] HFP + HBP less than d-phy, FPS will under 60Hz
>
> Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
> ---
> drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index 3cc9fb0d4f5d..dc276c346fd1 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -2139,9 +2139,9 @@ static const struct panel_desc starry_himax83102_j02_desc = {
> static const struct drm_display_mode starry_ili9882t_default_mode = {
> .clock = 165280,
> .hdisplay = 1200,
> - .hsync_start = 1200 + 32,
> - .hsync_end = 1200 + 32 + 30,
> - .htotal = 1200 + 32 + 30 + 32,
> + .hsync_start = 1200 + 72,
> + .hsync_end = 1200 + 72 + 30,
> + .htotal = 1200 + 72 + 30 + 72,
> .vdisplay = 1920,
> .vsync_start = 1920 + 68,
> .vsync_end = 1920 + 68 + 2,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
but can you resend with a appropriate Fixes tag ?
thanks,
Neil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-26 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-26 12:07 [PATCH] drm/panel: Fine tune Starry-ili9882t panel HFP and HBP Cong Yang
2023-06-26 13:38 ` neil.armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®