* [PATCH 1/1] arm64: dts: imx8mn-solidsense-n8-compact: drop undocumented adi,led-polarity
@ 2026-09-23 21:13 Frank.Li
2026-09-25 21:15 ` Rob Herring
2026-09-28 19:39 ` Frank.Li
0 siblings, 2 replies; 4+ messages in thread
From: Frank.Li @ 2026-09-23 21:13 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT...,
moderated list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT...,
open list
Cc: imx, Josua Mayer
From: Frank Li <Frank.Li@nxp.com>
Drop undocument property adi,led-polarity and adi,link-st-polarity.
ethernet-phy@0 status is disabled and no in tree overlay file to enable it.
Fixed below DTB_CHECK warnings:
arch/arm64/boot/dts/freescale/imx8mn-solidsense-n8-compact.dtb: ethernet-phy@0: adi,led-polarity: b'\x00\x00\x00\x01' is not of type 'object', 'integer', 'array', 'boolean', 'null'
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
cc: Josua Mayer <josua@solid-run.com>
---
arch/arm64/boot/dts/freescale/imx8mn-solidsense-n8-compact.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-solidsense-n8-compact.dts b/arch/arm64/boot/dts/freescale/imx8mn-solidsense-n8-compact.dts
index c8c6760524dbe..9b8b971c1a5c2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-solidsense-n8-compact.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-solidsense-n8-compact.dts
@@ -226,8 +226,6 @@ phy0: ethernet-phy@0 {
reset-assert-us = <10>;
reset-deassert-us = <5000>;
reset-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
- adi,led-polarity = <GPIO_ACTIVE_LOW>;
- adi,link-st-polarity = <GPIO_ACTIVE_LOW>;
status = "disabled";
leds {
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm64: dts: imx8mn-solidsense-n8-compact: drop undocumented adi,led-polarity
2026-09-23 21:13 [PATCH 1/1] arm64: dts: imx8mn-solidsense-n8-compact: drop undocumented adi,led-polarity Frank.Li
@ 2026-09-25 21:15 ` Rob Herring
2026-09-28 13:22 ` Josua Mayer
2026-09-28 19:39 ` Frank.Li
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2026-09-25 21:15 UTC (permalink / raw)
To: Frank.Li
Cc: Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT...,
moderated list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT...,
open list, Josua Mayer
On Wed, Sep 23, 2026 at 4:13 PM <Frank.Li@oss.nxp.com> wrote:
>
> From: Frank Li <Frank.Li@nxp.com>
>
> Drop undocument property adi,led-polarity and adi,link-st-polarity.
> ethernet-phy@0 status is disabled and no in tree overlay file to enable it.
>
> Fixed below DTB_CHECK warnings:
> arch/arm64/boot/dts/freescale/imx8mn-solidsense-n8-compact.dtb: ethernet-phy@0: adi,led-polarity: b'\x00\x00\x00\x01' is not of type 'object', 'integer', 'array', 'boolean', 'null'
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> cc: Josua Mayer <josua@solid-run.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mn-solidsense-n8-compact.dts | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm64: dts: imx8mn-solidsense-n8-compact: drop undocumented adi,led-polarity
2026-09-25 21:15 ` Rob Herring
@ 2026-09-28 13:22 ` Josua Mayer
0 siblings, 0 replies; 4+ messages in thread
From: Josua Mayer @ 2026-09-28 13:22 UTC (permalink / raw)
To: Rob Herring, Frank.Li
Cc: Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT...,
moderated list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT...,
open list
Am 25.09.26 um 23:15 schrieb Rob Herring:
> On Wed, Sep 23, 2026 at 4:13 PM <Frank.Li@oss.nxp.com> wrote:
>> From: Frank Li <Frank.Li@nxp.com>
>>
>> Drop undocument property adi,led-polarity and adi,link-st-polarity.
>> ethernet-phy@0 status is disabled and no in tree overlay file to enable it.
Drop them only because undocumented please,
the phy node is enabled by bootloader depending on board version.
For reference:
https://lore.kernel.org/all/b6f5ff0f-65e1-4b46-8f18-edf24ab3cea5@solid-run.com/
Including it in the upstream dts was a mistake, dropping the props is
correct.
Reviewed-by: Josua Mayer <josua@solid-run.com>
>>
>> Fixed below DTB_CHECK warnings:
>> arch/arm64/boot/dts/freescale/imx8mn-solidsense-n8-compact.dtb: ethernet-phy@0: adi,led-polarity: b'\x00\x00\x00\x01' is not of type 'object', 'integer', 'array', 'boolean', 'null'
>>
>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>> ---
>> cc: Josua Mayer <josua@solid-run.com>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mn-solidsense-n8-compact.dts | 2 --
>> 1 file changed, 2 deletions(-)
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm64: dts: imx8mn-solidsense-n8-compact: drop undocumented adi,led-polarity
2026-09-23 21:13 [PATCH 1/1] arm64: dts: imx8mn-solidsense-n8-compact: drop undocumented adi,led-polarity Frank.Li
2026-09-25 21:15 ` Rob Herring
@ 2026-09-28 19:39 ` Frank.Li
1 sibling, 0 replies; 4+ messages in thread
From: Frank.Li @ 2026-09-28 19:39 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, devicetree, imx,
linux-arm-kernel, linux-kernel, Frank.Li
Cc: Frank Li, Josua Mayer
From: Frank Li <Frank.Li@nxp.com>
On Wed, 23 Sep 2026 17:13:11 -0400, Frank.Li@oss.nxp.com wrote:
> Drop undocument property adi,led-polarity and adi,link-st-polarity.
> ethernet-phy@0 status is disabled and no in tree overlay file to enable it.
>
> Fixed below DTB_CHECK warnings:
> arch/arm64/boot/dts/freescale/imx8mn-solidsense-n8-compact.dtb: ethernet-phy@0: adi,led-polarity: b'\x00\x00\x00\x01' is not of type 'object', 'integer', 'array', 'boolean', 'null'
>
>
> [...]
Applied, thanks!
[1/1] arm64: dts: imx8mn-solidsense-n8-compact: drop undocumented adi,led-polarity
commit: fbbb3324b517f7cc59d424bbb90266cc1b13943d
Best regards,
--
Frank Li <Frank.Li@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-28 19:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-23 21:13 [PATCH 1/1] arm64: dts: imx8mn-solidsense-n8-compact: drop undocumented adi,led-polarity Frank.Li
2026-09-25 21:15 ` Rob Herring
2026-09-28 13:22 ` Josua Mayer
2026-09-28 19:39 ` Frank.Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®