From: Chanwoo Choi <cw00.choi@samsung.com>
To: Hans de Goede <hdegoede@redhat.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Stephan Gerhold <stephan@gerhold.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] extcon: int3496: Make the driver a bit less verbose
Date: Wed, 16 Feb 2022 10:27:17 +0900 [thread overview]
Message-ID: <5c632a6c-cb85-a941-1ad3-b0ed20b2082b@samsung.com> (raw)
In-Reply-To: <20211228170141.520902-1-hdegoede@redhat.com>
On 12/29/21 2:01 AM, Hans de Goede wrote:
> On all devices which I have with an INT3496 ACPI device,
> there is only an ID pin defined.
>
> Change the log-messages about not being able to get GPIOs for
> "VBUS EN" and "USB MUX" to use dev_dbg().
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/extcon/extcon-intel-int3496.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
> index fb527c23639e..df6ab4ef46f5 100644
> --- a/drivers/extcon/extcon-intel-int3496.c
> +++ b/drivers/extcon/extcon-intel-int3496.c
> @@ -121,11 +121,11 @@ static int int3496_probe(struct platform_device *pdev)
>
> data->gpio_vbus_en = devm_gpiod_get(dev, "vbus", GPIOD_ASIS);
> if (IS_ERR(data->gpio_vbus_en))
> - dev_info(dev, "can't request VBUS EN GPIO\n");
> + dev_dbg(dev, "can't request VBUS EN GPIO\n");
>
> data->gpio_usb_mux = devm_gpiod_get(dev, "mux", GPIOD_ASIS);
> if (IS_ERR(data->gpio_usb_mux))
> - dev_info(dev, "can't request USB MUX GPIO\n");
> + dev_dbg(dev, "can't request USB MUX GPIO\n");
>
> /* register extcon device */
> data->edev = devm_extcon_dev_allocate(dev, int3496_cable);
>
Applied them (patch1-4). Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
prev parent reply other threads:[~2022-02-16 1:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20211228170156epcas1p2a0dea22755f2336b01c6e06b289d9583@epcas1p2.samsung.com>
2021-12-28 17:01 ` Hans de Goede
2021-12-28 17:01 ` [PATCH 2/4] extcon: int3496: Request non-exclusive access to the ID GPIO Hans de Goede
2021-12-28 17:01 ` [PATCH 3/4] extcon: int3496: Add support for binding to plain platform devices Hans de Goede
2021-12-28 17:01 ` [PATCH 4/4] extcon: int3496: Add support for controlling Vbus through a regulator Hans de Goede
2022-02-16 1:27 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c632a6c-cb85-a941-1ad3-b0ed20b2082b@samsung.com \
--to=cw00.choi@samsung.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®