mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Francesco Lavra <flavra@baylibre.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH v8 2/6] iio: Replace 'sign' field with union in struct iio_scan_type
Date: Mon, 23 Mar 2026 18:37:38 +0100	[thread overview]
Message-ID: <5c780b1be8a64f7862a421db5a1f5be861cb197c.camel@baylibre.com> (raw)
In-Reply-To: <acFvHgTo-3cxH_UP@ashevche-desk.local>

On Mon, 2026-03-23 at 18:49 +0200, Andy Shevchenko wrote:
> On Mon, Mar 23, 2026 at 05:04:10PM +0100, Francesco Lavra wrote:
> > On Sat, 2026-03-21 at 12:22 -0500, David Lechner wrote:
> > > On 3/17/26 10:04 AM, Francesco Lavra wrote:
> 
> ...
> 
> > > > + * @IIO_SCAN_FORMAT_SIGNED_INT: Signed integer (two's complement).
> > > > + * @IIO_SCAN_FORMAT_UNSIGNED_INT: Unsigned integer.
> 
> > > We could make this proper kernel doc format with one comment per
> > > macro.
> > 
> > Actually, a set of related #defines can be documented with a single
> > comment. I see a few examples doing that in include/linux/gfp_types.h
> > and
> > include/linux/fpga/fpga-mgr.h
> > 
> > > > +#define IIO_SCAN_FORMAT_SIGNED_INT     's'
> > > > +#define IIO_SCAN_FORMAT_UNSIGNED_INT   'u'
> 
> ...or use enum
> 
> /**
>  * ...kernel-doc for enum...
>  */
> enum {
>         IIO_SCAN_FORMAT_SIGNED_INT = 's',
>         IIO_SCAN_FORMAT_UNSIGNED_INT = 'u',
> };

There is no standard kernel-doc format for anonymous enums.


  reply	other threads:[~2026-03-23 17:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 15:03 [PATCH v8 0/6] imu: st_lsm6dsx: Add support for rotation sensor Francesco Lavra
2026-03-17 15:03 ` [PATCH v8 1/6] iio: imu: st_lsm6dsx: Fix check for invalid samples from FIFO Francesco Lavra
2026-03-17 15:04 ` [PATCH v8 2/6] iio: Replace 'sign' field with union in struct iio_scan_type Francesco Lavra
2026-03-21 17:22   ` David Lechner
2026-03-23 16:04     ` Francesco Lavra
2026-03-23 16:08       ` David Lechner
2026-03-23 16:49       ` Andy Shevchenko
2026-03-23 17:37         ` Francesco Lavra [this message]
2026-03-24 11:04           ` Andy Shevchenko
2026-03-24 11:42             ` Francesco Lavra
2026-03-24 11:52               ` Andy Shevchenko
2026-03-17 15:04 ` [PATCH v8 3/6] iio: tools: Add support for floating-point types in buffer scan elements Francesco Lavra
2026-03-21 17:26   ` David Lechner
2026-03-17 15:04 ` [PATCH v8 4/6] iio: ABI: Add support for floating-point numbers " Francesco Lavra
2026-03-17 15:04 ` [PATCH v8 5/6] iio: ABI: Add quaternion axis modifier Francesco Lavra
2026-03-21 17:29   ` David Lechner
2026-03-17 15:04 ` [PATCH v8 6/6] iio: imu: st_lsm6dsx: Add support for rotation sensor Francesco Lavra
2026-03-21 17:46   ` David Lechner
2026-03-21 18:51   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c780b1be8a64f7862a421db5a1f5be861cb197c.camel@baylibre.com \
    --to=flavra@baylibre.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®