* [PATCH] drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps
@ 2020-08-20 5:26 Furquan Shaikh
2020-08-20 7:16 ` Christian König
2020-08-20 7:52 ` [PATCH v2] " Furquan Shaikh
0 siblings, 2 replies; 5+ messages in thread
From: Furquan Shaikh @ 2020-08-20 5:26 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher
Cc: Christian König, David Airlie, Daniel Vetter,
Nicholas Kazlauskas, Bhawanpreet Lakha, Stylon Wang, Roman Li,
Mikita Lipski, amd-gfx, dri-devel, linux-kernel, adurbin,
deepak.sharma, Furquan Shaikh
In `amdgpu_dm_update_backlight_caps()`, there is a local
`amdgpu_dm_backlight_caps` object that is filled in by
`amdgpu_acpi_get_backlight_caps()`. However, this object is
uninitialized before the call and hence the subsequent check for
aux_support can fail since it is not initialized by
`amdgpu_acpi_get_backlight_caps()` as well. This change initializes
this local `amdgpu_dm_backlight_caps` object to 0.
Signed-off-by: Furquan Shaikh <furquan@google.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index e4b33c67b634..725d8af634ee 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -2853,7 +2853,7 @@ static int amdgpu_dm_mode_config_init(struct amdgpu_device *adev)
static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm)
{
#if defined(CONFIG_ACPI)
- struct amdgpu_dm_backlight_caps caps;
+ struct amdgpu_dm_backlight_caps caps = { 0 };
if (dm->backlight_caps.caps_valid)
return;
--
2.28.0.297.g1956fa8f8d-goog
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps
2020-08-20 5:26 [PATCH] drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps Furquan Shaikh
@ 2020-08-20 7:16 ` Christian König
2020-08-20 7:52 ` [PATCH v2] " Furquan Shaikh
1 sibling, 0 replies; 5+ messages in thread
From: Christian König @ 2020-08-20 7:16 UTC (permalink / raw)
To: Furquan Shaikh, Harry Wentland, Leo Li, Alex Deucher
Cc: David Airlie, Daniel Vetter, Nicholas Kazlauskas,
Bhawanpreet Lakha, Stylon Wang, Roman Li, Mikita Lipski, amd-gfx,
dri-devel, linux-kernel, adurbin, deepak.sharma
Am 20.08.20 um 07:26 schrieb Furquan Shaikh:
> In `amdgpu_dm_update_backlight_caps()`, there is a local
> `amdgpu_dm_backlight_caps` object that is filled in by
> `amdgpu_acpi_get_backlight_caps()`. However, this object is
> uninitialized before the call and hence the subsequent check for
> aux_support can fail since it is not initialized by
> `amdgpu_acpi_get_backlight_caps()` as well. This change initializes
> this local `amdgpu_dm_backlight_caps` object to 0.
>
> Signed-off-by: Furquan Shaikh <furquan@google.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index e4b33c67b634..725d8af634ee 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -2853,7 +2853,7 @@ static int amdgpu_dm_mode_config_init(struct amdgpu_device *adev)
> static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm)
> {
> #if defined(CONFIG_ACPI)
> - struct amdgpu_dm_backlight_caps caps;
> + struct amdgpu_dm_backlight_caps caps = { 0 };
Please use memset instead of "{ 0 }" for initialization.
Christian.
>
> if (dm->backlight_caps.caps_valid)
> return;
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps
2020-08-20 5:26 [PATCH] drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps Furquan Shaikh
2020-08-20 7:16 ` Christian König
@ 2020-08-20 7:52 ` Furquan Shaikh
2020-08-20 9:01 ` Christian König
1 sibling, 1 reply; 5+ messages in thread
From: Furquan Shaikh @ 2020-08-20 7:52 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher
Cc: Christian König, David Airlie, Daniel Vetter,
Nicholas Kazlauskas, Bhawanpreet Lakha, Stylon Wang, Roman Li,
Mikita Lipski, amd-gfx, dri-devel, linux-kernel, adurbin,
deepak.sharma, Furquan Shaikh
In `amdgpu_dm_update_backlight_caps()`, there is a local
`amdgpu_dm_backlight_caps` object that is filled in by
`amdgpu_acpi_get_backlight_caps()`. However, this object is
uninitialized before the call and hence the subsequent check for
aux_support can fail since it is not initialized by
`amdgpu_acpi_get_backlight_caps()` as well. This change initializes
this local `amdgpu_dm_backlight_caps` object to 0.
Signed-off-by: Furquan Shaikh <furquan@google.com>
---
v2: Switched to using memset for initialization of object.
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index e4b33c67b634..da072998ce48 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -2855,6 +2855,8 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm)
#if defined(CONFIG_ACPI)
struct amdgpu_dm_backlight_caps caps;
+ memset(&caps, 0, sizeof(caps));
+
if (dm->backlight_caps.caps_valid)
return;
--
2.28.0.297.g1956fa8f8d-goog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps
2020-08-20 7:52 ` [PATCH v2] " Furquan Shaikh
@ 2020-08-20 9:01 ` Christian König
2020-08-20 18:20 ` Alex Deucher
0 siblings, 1 reply; 5+ messages in thread
From: Christian König @ 2020-08-20 9:01 UTC (permalink / raw)
To: Furquan Shaikh, Harry Wentland, Leo Li, Alex Deucher
Cc: David Airlie, Daniel Vetter, Nicholas Kazlauskas,
Bhawanpreet Lakha, Stylon Wang, Roman Li, Mikita Lipski, amd-gfx,
dri-devel, linux-kernel, adurbin, deepak.sharma
Am 20.08.20 um 09:52 schrieb Furquan Shaikh:
> In `amdgpu_dm_update_backlight_caps()`, there is a local
> `amdgpu_dm_backlight_caps` object that is filled in by
> `amdgpu_acpi_get_backlight_caps()`. However, this object is
> uninitialized before the call and hence the subsequent check for
> aux_support can fail since it is not initialized by
> `amdgpu_acpi_get_backlight_caps()` as well. This change initializes
> this local `amdgpu_dm_backlight_caps` object to 0.
>
> Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> v2: Switched to using memset for initialization of object.
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index e4b33c67b634..da072998ce48 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -2855,6 +2855,8 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm)
> #if defined(CONFIG_ACPI)
> struct amdgpu_dm_backlight_caps caps;
>
> + memset(&caps, 0, sizeof(caps));
> +
> if (dm->backlight_caps.caps_valid)
> return;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps
2020-08-20 9:01 ` Christian König
@ 2020-08-20 18:20 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2020-08-20 18:20 UTC (permalink / raw)
To: Christian König
Cc: Furquan Shaikh, Harry Wentland, Leo Li, Alex Deucher,
Stylon Wang, deepak.sharma, David Airlie, adurbin, Roman Li,
amd-gfx list, LKML, Maling list - DRI developers, Mikita Lipski,
Bhawanpreet Lakha, Nicholas Kazlauskas
Applied. Thanks!
Alex
On Thu, Aug 20, 2020 at 5:01 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Am 20.08.20 um 09:52 schrieb Furquan Shaikh:
> > In `amdgpu_dm_update_backlight_caps()`, there is a local
> > `amdgpu_dm_backlight_caps` object that is filled in by
> > `amdgpu_acpi_get_backlight_caps()`. However, this object is
> > uninitialized before the call and hence the subsequent check for
> > aux_support can fail since it is not initialized by
> > `amdgpu_acpi_get_backlight_caps()` as well. This change initializes
> > this local `amdgpu_dm_backlight_caps` object to 0.
> >
> > Signed-off-by: Furquan Shaikh <furquan@google.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> > ---
> > v2: Switched to using memset for initialization of object.
> >
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index e4b33c67b634..da072998ce48 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -2855,6 +2855,8 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm)
> > #if defined(CONFIG_ACPI)
> > struct amdgpu_dm_backlight_caps caps;
> >
> > + memset(&caps, 0, sizeof(caps));
> > +
> > if (dm->backlight_caps.caps_valid)
> > return;
> >
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-20 18:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-20 5:26 [PATCH] drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps Furquan Shaikh
2020-08-20 7:16 ` Christian König
2020-08-20 7:52 ` [PATCH v2] " Furquan Shaikh
2020-08-20 9:01 ` Christian König
2020-08-20 18:20 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®