mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: Michal Simek <michal.simek@amd.com>,
	"Rob Herring (Arm)" <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: xilinx: Drop undocumented "always-on" properties
Date: Fri, 29 Aug 2025 08:25:40 +0200	[thread overview]
Message-ID: <5ca5b18a-96bc-41da-8784-171116d75b50@topic.nl> (raw)
In-Reply-To: <769c2a21-15c7-4c6d-84b7-cf1153106dfb@amd.com>

On 29-08-2025 07:46, Michal Simek wrote:
> Hi,
>
> On 8/28/25 23:30, Rob Herring (Arm) wrote:
>> The "always-on" properties are not documented for "silabs,si5341"
>> binding nor used by the Linux driver, so drop them.
>
> Binding
> Documentation/devicetree/bindings/clock/silabs,si5341.txt
> doesn't contain it
> but driver drivers/clk/clk-si5341.c is reading it.
>
> 1345                 config[num].always_on =
> 1346                         of_property_read_bool(child, "always-on");
>
> It is there from 2019 when driver has been added.
>
> If it is not standard clock property it should be moved to standard one.

Agree - either "always-on" should become a standard property, or it should be 
removed from the driver.

As a standard property, akin to "regulator-always-on", maybe it should 
probably be renamed to "clock-always-on"?

I'd be happy to provide a patch either way.


> And DT binding should be converted to yaml with all properties used today.
>
> Thanks,
> Michal
>
>
Mike.





  reply	other threads:[~2025-08-29  6:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 21:30 Rob Herring (Arm)
2025-08-29  5:46 ` Michal Simek
2025-08-29  6:25   ` Mike Looijmans [this message]
2025-08-29  7:02     ` Krzysztof Kozlowski
2025-09-04  0:56   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ca5b18a-96bc-41da-8784-171116d75b50@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®