Re: [PATCH] arm64: dts: xilinx: Drop undocumented "always-on" properties

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/08/2025 08:25, Mike Looijmans wrote:
> On 29-08-2025 07:46, Michal Simek wrote:
>> Hi,
>>
>> On 8/28/25 23:30, Rob Herring (Arm) wrote:
>>> The "always-on" properties are not documented for "silabs,si5341"
>>> binding nor used by the Linux driver, so drop them.
>>
>> Binding
>> Documentation/devicetree/bindings/clock/silabs,si5341.txt
>> doesn't contain it
>> but driver drivers/clk/clk-si5341.c is reading it.
>>
>> 1345                 config[num].always_on =
>> 1346                         of_property_read_bool(child, "always-on");
>>
>> It is there from 2019 when driver has been added.
>>
>> If it is not standard clock property it should be moved to standard one.
> 
> Agree - either "always-on" should become a standard property, or it should be 
> removed from the driver.
> 
> As a standard property, akin to "regulator-always-on", maybe it should 
> probably be renamed to "clock-always-on"?
> 
> I'd be happy to provide a patch either way.

That's an implied ABI now, so you cannot remove it, but about
"clock-always-on" - it does not look like a property we want in DT. If
on one board this is always connected (but on other not), you should
take the proper clock reference.

> 


Best regards,
Krzysztof