* [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays
@ 2024-05-24 15:01 Junhao Xie
2024-05-24 15:23 ` Konrad Dybcio
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Junhao Xie @ 2024-05-24 15:01 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, Konrad Dybcio,
Ryan McCann, Neil Armstrong, Jonathan Marek
Cc: Junhao Xie, linux-arm-msm, dri-devel, freedreno, linux-kernel
There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv,
which cause weston assertions failed.
weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format:
Assertion `!weston_drm_format_array_find_format(formats, format)' failed.
Signed-off-by: Junhao Xie <bigfoot@classfun.cn>
---
| 6 ------
1 file changed, 6 deletions(-)
--git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index 47fd8baf53e6..3138e73c04f1 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
@@ -216,12 +216,9 @@ static const u32 wb2_formats_rgb[] = {
DRM_FORMAT_RGBA4444,
DRM_FORMAT_RGBX4444,
DRM_FORMAT_XRGB4444,
- DRM_FORMAT_BGR565,
DRM_FORMAT_BGR888,
- DRM_FORMAT_ABGR8888,
DRM_FORMAT_BGRA8888,
DRM_FORMAT_BGRX8888,
- DRM_FORMAT_XBGR8888,
DRM_FORMAT_ABGR1555,
DRM_FORMAT_BGRA5551,
DRM_FORMAT_XBGR1555,
@@ -250,12 +247,9 @@ static const u32 wb2_formats_rgb_yuv[] = {
DRM_FORMAT_RGBA4444,
DRM_FORMAT_RGBX4444,
DRM_FORMAT_XRGB4444,
- DRM_FORMAT_BGR565,
DRM_FORMAT_BGR888,
- DRM_FORMAT_ABGR8888,
DRM_FORMAT_BGRA8888,
DRM_FORMAT_BGRX8888,
- DRM_FORMAT_XBGR8888,
DRM_FORMAT_ABGR1555,
DRM_FORMAT_BGRA5551,
DRM_FORMAT_XBGR1555,
--
2.44.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays
2024-05-24 15:01 [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays Junhao Xie
@ 2024-05-24 15:23 ` Konrad Dybcio
2024-05-24 18:19 ` Abhinav Kumar
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2024-05-24 15:23 UTC (permalink / raw)
To: Junhao Xie, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, Marijn Suijten, David Airlie, Daniel Vetter,
Ryan McCann, Neil Armstrong, Jonathan Marek
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 24.05.2024 5:01 PM, Junhao Xie wrote:
> There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv,
> which cause weston assertions failed.
>
> weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format:
> Assertion `!weston_drm_format_array_find_format(formats, format)' failed.
>
> Signed-off-by: Junhao Xie <bigfoot@classfun.cn>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays
2024-05-24 15:01 [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays Junhao Xie
2024-05-24 15:23 ` Konrad Dybcio
@ 2024-05-24 18:19 ` Abhinav Kumar
2024-05-24 20:24 ` Dmitry Baryshkov
2024-06-03 21:20 ` Dmitry Baryshkov
2024-06-05 20:08 ` Abhinav Kumar
3 siblings, 1 reply; 6+ messages in thread
From: Abhinav Kumar @ 2024-05-24 18:19 UTC (permalink / raw)
To: Junhao Xie, Rob Clark, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, Konrad Dybcio,
Ryan McCann, Neil Armstrong, Jonathan Marek
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 5/24/2024 8:01 AM, Junhao Xie wrote:
> There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv,
> which cause weston assertions failed.
>
> weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format:
> Assertion `!weston_drm_format_array_find_format(formats, format)' failed.
>
> Signed-off-by: Junhao Xie <bigfoot@classfun.cn>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 ------
> 1 file changed, 6 deletions(-)
>
I think we need two fixes tag here, one for the RGB array and the other
one for the RGB+YUV array.
Fixes: 8c16b988ba2d ("drm/msm/dpu: introduce separate wb2_format arrays
for rgb and yuv")
Fixes: 53324b99bd7b ("drm/msm/dpu: add writeback blocks to the sm8250
DPU catalog")
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
(pls ignore the line breaks in the fixes line, I will fix it while applying)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays
2024-05-24 18:19 ` Abhinav Kumar
@ 2024-05-24 20:24 ` Dmitry Baryshkov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2024-05-24 20:24 UTC (permalink / raw)
To: Abhinav Kumar
Cc: Junhao Xie, Rob Clark, Sean Paul, Marijn Suijten, David Airlie,
Daniel Vetter, Konrad Dybcio, Ryan McCann, Neil Armstrong,
Jonathan Marek, linux-arm-msm, dri-devel, freedreno,
linux-kernel
On Fri, May 24, 2024 at 11:19:41AM -0700, Abhinav Kumar wrote:
>
>
> On 5/24/2024 8:01 AM, Junhao Xie wrote:
> > There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv,
> > which cause weston assertions failed.
> >
> > weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format:
> > Assertion `!weston_drm_format_array_find_format(formats, format)' failed.
> >
> > Signed-off-by: Junhao Xie <bigfoot@classfun.cn>
> > ---
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
>
> I think we need two fixes tag here, one for the RGB array and the other one
> for the RGB+YUV array.
>
> Fixes: 8c16b988ba2d ("drm/msm/dpu: introduce separate wb2_format arrays for
> rgb and yuv")
>
> Fixes: 53324b99bd7b ("drm/msm/dpu: add writeback blocks to the sm8250 DPU
> catalog")
>
> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>
> (pls ignore the line breaks in the fixes line, I will fix it while applying)
With the Fixes tags in place:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays
2024-05-24 15:01 [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays Junhao Xie
2024-05-24 15:23 ` Konrad Dybcio
2024-05-24 18:19 ` Abhinav Kumar
@ 2024-06-03 21:20 ` Dmitry Baryshkov
2024-06-05 20:08 ` Abhinav Kumar
3 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2024-06-03 21:20 UTC (permalink / raw)
To: Junhao Xie
Cc: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
David Airlie, Daniel Vetter, Konrad Dybcio, Ryan McCann,
Neil Armstrong, Jonathan Marek, linux-arm-msm, dri-devel,
freedreno, linux-kernel
On Fri, May 24, 2024 at 11:01:12PM +0800, Junhao Xie wrote:
> There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv,
> which cause weston assertions failed.
>
> weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format:
> Assertion `!weston_drm_format_array_find_format(formats, format)' failed.
>
> Signed-off-by: Junhao Xie <bigfoot@classfun.cn>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 ------
> 1 file changed, 6 deletions(-)
>
To make patchwork happy:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Fixes: 8c16b988ba2d ("drm/msm/dpu: introduce separate wb2_format arrays for rgb and yuv")
Fixes: 53324b99bd7b ("drm/msm/dpu: add writeback blocks to the sm8250 DPU catalog")
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays
2024-05-24 15:01 [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays Junhao Xie
` (2 preceding siblings ...)
2024-06-03 21:20 ` Dmitry Baryshkov
@ 2024-06-05 20:08 ` Abhinav Kumar
3 siblings, 0 replies; 6+ messages in thread
From: Abhinav Kumar @ 2024-06-05 20:08 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Sean Paul, Marijn Suijten,
David Airlie, Daniel Vetter, Konrad Dybcio, Ryan McCann,
Neil Armstrong, Jonathan Marek, Junhao Xie
Cc: Abhinav Kumar, linux-arm-msm, dri-devel, freedreno, linux-kernel
On Fri, 24 May 2024 23:01:12 +0800, Junhao Xie wrote:
> There are duplicate items in wb2_formats_rgb and wb2_formats_rgb_yuv,
> which cause weston assertions failed.
>
> weston: libweston/drm-formats.c:131: weston_drm_format_array_add_format:
> Assertion `!weston_drm_format_array_find_format(formats, format)' failed.
>
>
> [...]
Applied, thanks!
[1/1] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays
https://gitlab.freedesktop.org/abhinavk/msm-next/-/commit/3788ddf084b7
Best regards,
--
Abhinav Kumar <quic_abhinavk@quicinc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-05 20:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-24 15:01 [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays Junhao Xie
2024-05-24 15:23 ` Konrad Dybcio
2024-05-24 18:19 ` Abhinav Kumar
2024-05-24 20:24 ` Dmitry Baryshkov
2024-06-03 21:20 ` Dmitry Baryshkov
2024-06-05 20:08 ` Abhinav Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®