From: Dan Carpenter <dan.carpenter@linaro.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Wang Ming <machel@vivo.com>,
opensource.kernel@vivo.com, kernel-janitors@vger.kernel.org,
ntb@lists.linux.dev, Allen Hubbe <allenbh@gmail.com>,
Dan Carpenter <error27@gmail.com>,
Dave Jiang <dave.jiang@intel.com>,
Jiasheng Jiang <jiasheng@iscas.ac.cn>,
Jon Mason <jdmason@kudzu.us>, LKML <linux-kernel@vger.kernel.org>,
Minjie Du <duminjie@vivo.com>
Subject: Re: [PATCH v3] ntb: Remove error checking for debugfs_create_dir()
Date: Fri, 14 Jul 2023 17:08:24 +0300 [thread overview]
Message-ID: <5d0cd0e0-d92e-42d3-a6d9-ec9fc3229b7b@kadam.mountain> (raw)
In-Reply-To: <b5139e22-cf5e-e95c-fd33-7e1b9b4d665b@web.de>
On Fri, Jul 14, 2023 at 02:44:11PM +0200, Markus Elfring wrote:
> > > It is expected that most callers should _ignore_ the errors
> > > return by debugfs_create_dir() in tool_setup_dbgfs()
> …
> > The patch itself is correct for sure:
> > Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
>
> How does such information fit to the Linux development requirement
> for imperative change descriptions?
>
Markus, you already replied to this thread.
Greg, HCH, Matthew Wilcox and Krzysztof Kozlowski have all asked you to
stop. Those are respected kernel maintainers. You should listen to
them.
If you see a bug, that's useful. But if you're just nitpicking the
commit message, that's not useful. We have explained this many times as
clearly as we know how.
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94
>
>
> How do you think about to add the tag “Fixes” because of the deletion
> of an inappropriate error detection?
No. It's not a bug fix so a Fixes tag is innappropriate.
regards,
dan carpenter
prev parent reply other threads:[~2023-07-14 14:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 8:56 Wang Ming
2023-07-13 9:27 ` Dan Carpenter
[not found] ` <SG2PR06MB3743648B9D54AF2D6CB4229ABD37A@SG2PR06MB3743.apcprd06.prod.outlook.com>
2023-07-13 10:14 ` 回复: " Dan Carpenter
2023-07-13 16:05 ` Dave Jiang
[not found] ` <e93e7bb2-c254-06e2-87b7-1f59e52930f6@web.de>
2023-07-14 5:57 ` Dan Carpenter
2023-07-14 10:00 ` Serge Semin
[not found] ` <b5139e22-cf5e-e95c-fd33-7e1b9b4d665b@web.de>
2023-07-14 14:03 ` Serge Semin
2023-07-14 14:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d0cd0e0-d92e-42d3-a6d9-ec9fc3229b7b@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=Markus.Elfring@web.de \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=duminjie@vivo.com \
--cc=error27@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=jdmason@kudzu.us \
--cc=jiasheng@iscas.ac.cn \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=machel@vivo.com \
--cc=ntb@lists.linux.dev \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®