From: Dave Jiang <dave.jiang@intel.com>
To: Wang Ming <machel@vivo.com>, Jon Mason <jdmason@kudzu.us>,
Allen Hubbe <allenbh@gmail.com>,
Serge Semin <fancer.lancer@gmail.com>,
Dan Carpenter <error27@gmail.com>,
Jiasheng Jiang <jiasheng@iscas.ac.cn>, <ntb@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Cc: <opensource.kernel@vivo.com>, <dan.carpenter@linaro.org>
Subject: Re: [PATCH v3] ntb: Remove error checking for debugfs_create_dir()
Date: Thu, 13 Jul 2023 09:05:03 -0700 [thread overview]
Message-ID: <9a1062c3-f5be-ea69-0672-cf1a44be7e03@intel.com> (raw)
In-Reply-To: <20230713085621.3380-1-machel@vivo.com>
On 7/13/23 01:56, Wang Ming wrote:
> It is expected that most callers should _ignore_ the errors
> return by debugfs_create_dir() in tool_setup_dbgfs()
>
> Signed-off-by: Wang Ming <machel@vivo.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/ntb/test/ntb_tool.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> index eeeb4b1c97d2..e0acc11d29ba 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -1495,8 +1495,6 @@ static void tool_setup_dbgfs(struct tool_ctx *tc)
>
> tc->dbgfs_dir = debugfs_create_dir(dev_name(&tc->ntb->dev),
> tool_dbgfs_topdir);
> - if (!tc->dbgfs_dir)
> - return;
>
> debugfs_create_file("port", 0600, tc->dbgfs_dir,
> tc, &tool_port_fops);
next prev parent reply other threads:[~2023-07-13 16:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 8:56 Wang Ming
2023-07-13 9:27 ` Dan Carpenter
[not found] ` <SG2PR06MB3743648B9D54AF2D6CB4229ABD37A@SG2PR06MB3743.apcprd06.prod.outlook.com>
2023-07-13 10:14 ` 回复: " Dan Carpenter
2023-07-13 16:05 ` Dave Jiang [this message]
[not found] ` <e93e7bb2-c254-06e2-87b7-1f59e52930f6@web.de>
2023-07-14 5:57 ` Dan Carpenter
2023-07-14 10:00 ` Serge Semin
[not found] ` <b5139e22-cf5e-e95c-fd33-7e1b9b4d665b@web.de>
2023-07-14 14:03 ` Serge Semin
2023-07-14 14:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a1062c3-f5be-ea69-0672-cf1a44be7e03@intel.com \
--to=dave.jiang@intel.com \
--cc=allenbh@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=jdmason@kudzu.us \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=machel@vivo.com \
--cc=ntb@lists.linux.dev \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®