Re: [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3

[Guillaume La Roque <glaroque@baylibre.com>]

Hi,

Le 03/07/2025 à 14:28, Nishanth Menon a écrit :
> On 09:25-20250702, Matthias Schiffer wrote:
>> On Tue, 2025-07-01 at 20:57 +0200, Guillaume La Roque wrote:
>>>
>>> Le 01/07/2025 à 16:36, Matthias Schiffer a écrit :
>>>> On Mon, 2025-05-19 at 10:20 +0200, Guillaume La Roque wrote:
>>>>>
>>>>> After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver
>>>>> select on ARCH_K3 are not needed anymore.
>>>>> Select MAILBOX by default is not needed anymore[3],
>>>>> PM_GENERIC_DOMAIN if PM was enabled by default so not needed.
>>>>
>>>> Hi,
>>>
>>> Hi,
>>>
>>>>
>>>> what selects PM_GENERIC_DOMAIN in your configuration? linux-next fails to boot
>>>> on our AM62x-based TQMa62xx if I don't (partially) revert this patch - I have
>>>> not found a way to enable PM_GENERIC_DOMAIN and TI_SCI_PM_DOMAINS without
>>>> enabling other unneeded features to pull it in.
>>>>
>>> With master branch if i apply this patch and i do make ARCH=arm64
>>> defconfig and check in .config  both TI_SCI_PM_DOMAINS and
>>> PM_GENERIC_DOMAINS are enabled.
>>> with linux-next it's same. i don't really understand link with  PM part
>>> in this patch and boot issue on your SOM.
>>>
>>> I probably misunderstand something.
>>>
>>>
>>> what is your problem exactly ?
>>>
>>> if you can share log or link to jobs
>>
>>
>> Hi Guillaume,
>>
>> with arm64_defconfig, this problem doesn't occur, as other CONFIG_ARCH_* symbols
>> also have "select PM_GENERIC_DOMAINS" (with or without "if PM").
>>
>> We are using a smaller config specific to our K3-based SOMs however. I have
>> attached a defconfig that shows the problem - if you use this as the base for
>> .config on linux-next, there is no way to enable TI_SCI_PM_DOMAINS, as nothing
>> selects PM_GENERIC_DOMAINS.
>>
>> So unless I'm missing some other configuration that would actually be useful on
>> the K3 platform and that would pull in PM_GENERIC_DOMAINS, I think that part
>> needs to be reverted. I can send a patch to that effect later.
> 
> Is a better approach to select PM_GENERIC_DOMAINS in
> drivers/pmdomain/ti/Kconfig instead of depends (similar to what
> drivers/pmdomain/qcom/Kconfig or drivers/pmdomain/arm/Kconfig does since
> TI_SCI_PM_DOMAINS requires PM_GENERIC_DOMAINS?
> 

I send patch to do this :
https://lore.kernel.org/all/20250704-depspmdomain-v1-1-ef2710556e62@baylibre.com/

Regards
Guillaume