From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
Kukjin Kim <kgene@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
javier@osg.samsung.com, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 01/10] pinctrl: dt-bindings: samsung: Add header with values used for configuration
Date: Thu, 01 Sep 2016 13:13:02 +0200 [thread overview]
Message-ID: <5d29ca8c-2dfc-4477-9c5c-80254d6ddac4@samsung.com> (raw)
In-Reply-To: <3419428.Xfa2aHQ3xc@amdc1976>
On 09/01/2016 01:02 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Thursday, September 01, 2016 09:23:49 AM Krzysztof Kozlowski wrote:
>> Hard-coded pinctrl configuration values are scattered through DTS files.
>> The numbers are difficult to decode by human, especially without the
>> datasheet. Additionally the drive strength differs between Exynos SoC
>> families increasing the confusion.
>>
>> The header will help making this more readable and maintainable.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>> MAINTAINERS | 1 +
>> include/dt-bindings/pinctrl/samsung.h | 57 +++++++++++++++++++++++++++++++++++
>> 2 files changed, 58 insertions(+)
>> create mode 100644 include/dt-bindings/pinctrl/samsung.h
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index d8e81b1dde30..836bcd327ee4 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -9318,6 +9318,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>> L: linux-samsung-soc@vger.kernel.org (moderated for non-subscribers)
>> S: Maintained
>> F: drivers/pinctrl/samsung/
>> +F: include/dt-bindings/pinctrl/samsung.h
>>
>> PIN CONTROLLER - SINGLE
>> M: Tony Lindgren <tony@atomide.com>
>> diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h
>> new file mode 100644
>> index 000000000000..0f410ba5ec7e
>> --- /dev/null
>> +++ b/include/dt-bindings/pinctrl/samsung.h
>> @@ -0,0 +1,57 @@
>> +/*
>> + * Samsung's Exynos pinctrl bindings
>> + *
>> + * Copyright (c) 2016 Samsung Electronics Co., Ltd.
>> + * http://www.samsung.com
>> + * Author: Krzysztof Kozlowski <krzk@kernel.org>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> +*/
>> +
>> +#ifndef __DT_BINDINGS_PINCTRL_EXYNOS_H__
>> +#define __DT_BINDINGS_PINCTRL_EXYNOS_H__
>
> Minor nit:
>
> shouldn't this be __DT_BINDINGS_PINCTRL_SAMSUNG_H__ (the header file
> is named samsung.h and is going to be used also by s3c* SoCs)?
Yes, it should. Thanks!
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-09-01 11:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 7:23 [PATCH v2 00/10] pinctrl: exynos/samsung: " Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 01/10] pinctrl: dt-bindings: samsung: " Krzysztof Kozlowski
2016-09-01 9:00 ` [PATCH v2.1] " Krzysztof Kozlowski
2016-09-01 11:02 ` [PATCH v2 01/10] " Bartlomiej Zolnierkiewicz
2016-09-01 11:13 ` Krzysztof Kozlowski [this message]
2016-09-01 7:23 ` [PATCH v2 02/10] ARM: dts: exynos: Use common macros for pinctrl configuration Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 03/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos3250 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 04/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4210 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 05/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4x12 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 06/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4415 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 07/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5250 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 08/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5260 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 09/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5410 Krzysztof Kozlowski
2016-09-01 7:23 ` [PATCH v2 10/10] ARM: dts: exynos: Use macros for pinctrl configuration on exynos542x/exynos5800 Krzysztof Kozlowski
2016-09-01 10:14 ` [PATCH v2 00/10] pinctrl: exynos/samsung: Add header with values used for configuration Javier Martinez Canillas
2016-09-07 20:07 ` Linus Walleij
2016-09-07 20:20 ` Linus Walleij
[not found] ` <CGME20160916114244eucas1p2f585ef754b0523022a04a5646a06da36@eucas1p2.samsung.com>
2016-09-16 11:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d29ca8c-2dfc-4477-9c5c-80254d6ddac4@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®