* [PATCH next] reset: rzg2l-usbphy-ctrl: Fix a NULL vs IS_ERR() bug in probe
@ 2025-11-01 13:27 Dan Carpenter
2025-11-01 14:57 ` Claudiu Beznea
2025-11-06 10:44 ` Philipp Zabel
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-11-01 13:27 UTC (permalink / raw)
To: Claudiu Beznea; +Cc: Philipp Zabel, linux-kernel, kernel-janitors
The devm_regmap_field_alloc() function never returns NULL, it returns
error pointers. Update the error checking to match.
Fixes: 58128aa88867 ("reset: rzg2l-usbphy-ctrl: Add support for USB PWRRDY")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/reset/reset-rzg2l-usbphy-ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
index eea56687cd0a..4ecb9acb2641 100644
--- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
+++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
@@ -158,8 +158,8 @@ static int rzg2l_usbphy_ctrl_pwrrdy_init(struct device *dev)
field.msb = __fls(args[1]);
pwrrdy = devm_regmap_field_alloc(dev, regmap, field);
- if (!pwrrdy)
- return -ENOMEM;
+ if (IS_ERR(pwrrdy))
+ return PTR_ERR(pwrrdy);
rzg2l_usbphy_ctrl_set_pwrrdy(pwrrdy, true);
--
2.51.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH next] reset: rzg2l-usbphy-ctrl: Fix a NULL vs IS_ERR() bug in probe
2025-11-01 13:27 [PATCH next] reset: rzg2l-usbphy-ctrl: Fix a NULL vs IS_ERR() bug in probe Dan Carpenter
@ 2025-11-01 14:57 ` Claudiu Beznea
2025-11-06 10:44 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Claudiu Beznea @ 2025-11-01 14:57 UTC (permalink / raw)
To: Dan Carpenter, Claudiu Beznea
Cc: Philipp Zabel, linux-kernel, kernel-janitors
On 11/1/25 15:27, Dan Carpenter wrote:
> The devm_regmap_field_alloc() function never returns NULL, it returns
> error pointers. Update the error checking to match.
>
> Fixes: 58128aa88867 ("reset: rzg2l-usbphy-ctrl: Add support for USB PWRRDY")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
> drivers/reset/reset-rzg2l-usbphy-ctrl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> index eea56687cd0a..4ecb9acb2641 100644
> --- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> +++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c
> @@ -158,8 +158,8 @@ static int rzg2l_usbphy_ctrl_pwrrdy_init(struct device *dev)
> field.msb = __fls(args[1]);
>
> pwrrdy = devm_regmap_field_alloc(dev, regmap, field);
> - if (!pwrrdy)
> - return -ENOMEM;
> + if (IS_ERR(pwrrdy))
> + return PTR_ERR(pwrrdy);
>
> rzg2l_usbphy_ctrl_set_pwrrdy(pwrrdy, true);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH next] reset: rzg2l-usbphy-ctrl: Fix a NULL vs IS_ERR() bug in probe
2025-11-01 13:27 [PATCH next] reset: rzg2l-usbphy-ctrl: Fix a NULL vs IS_ERR() bug in probe Dan Carpenter
2025-11-01 14:57 ` Claudiu Beznea
@ 2025-11-06 10:44 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2025-11-06 10:44 UTC (permalink / raw)
To: Dan Carpenter, Claudiu Beznea; +Cc: linux-kernel, kernel-janitors
On Sa, 2025-11-01 at 16:27 +0300, Dan Carpenter wrote:
> The devm_regmap_field_alloc() function never returns NULL, it returns
> error pointers. Update the error checking to match.
>
> Fixes: 58128aa88867 ("reset: rzg2l-usbphy-ctrl: Add support for USB PWRRDY")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Applied to reset/next, thanks!
[1/1] reset: rzg2l-usbphy-ctrl: Fix a NULL vs IS_ERR() bug in probe
https://git.pengutronix.de/cgit/pza/linux/commit/?id=ce2883a0339c
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-06 10:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-01 13:27 [PATCH next] reset: rzg2l-usbphy-ctrl: Fix a NULL vs IS_ERR() bug in probe Dan Carpenter
2025-11-01 14:57 ` Claudiu Beznea
2025-11-06 10:44 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®