Re: [PATCH -tip] x86: do_boot_cpu - check if we have ESR register

["Glauber Costa" <glommer@gmail.com>]

On Wed, Oct 22, 2008 at 12:13 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
>
>> We should touch ESR register if only we have it.
>> The patch fixes the problem mentoined here
>>
>>       http://lkml.org/lkml/2008/10/17/147
>>
>> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
>> CC: Glauber Costa <glommer@gmail.com>
>
>> -             apic_write(APIC_ESR, 0);
>> -             apic_read(APIC_ESR);
>> +             if (APIC_INTEGRATED(apic_version[phys_apicid])) {
>> +                     apic_write(APIC_ESR, 0);
>> +                     apic_read(APIC_ESR);
>> +             }
>
> i'm wondering - is the server there really that old, that it has no
> integrated lapic? I.e. it's an i486 SMP box or so? Or perhaps some
> other, weird SMP box?

It's a Xeon, so probably just weird.

>
>        Ingo
>



-- 
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."