* [PATCH 1/2] mbox: qcom: add APCS child device for QCS404
@ 2019-08-26 16:46 Jorge Ramirez-Ortiz
2019-08-26 16:46 ` [PATCH 2/2] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
2019-08-28 22:31 ` [PATCH 1/2] mbox: qcom: add APCS child device for QCS404 Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Jorge Ramirez-Ortiz @ 2019-08-26 16:46 UTC (permalink / raw)
To: jorge.ramirez-ortiz, jassisinghbrar, agross
Cc: niklas.cassel, bjorn.andersson, linux-arm-msm, linux-kernel
There is clock controller functionality in the APCS hardware block of
qcs404 devices similar to msm8916.
Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
index 705e17a5479c..76e1ad433b3f 100644
--- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
+++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
@@ -89,7 +89,11 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
return ret;
}
- if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
+ platform_set_drvdata(pdev, apcs);
+
+ if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global") ||
+ of_device_is_compatible(np, "qcom,qcs404-apcs-apps-global")) {
+
apcs->clk = platform_device_register_data(&pdev->dev,
"qcom-apcs-msm8916-clk",
-1, NULL, 0);
@@ -97,8 +101,6 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "failed to register APCS clk\n");
}
- platform_set_drvdata(pdev, apcs);
-
return 0;
}
--
2.22.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 2/2] mbox: qcom: replace integer with valid macro
2019-08-26 16:46 [PATCH 1/2] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
@ 2019-08-26 16:46 ` Jorge Ramirez-Ortiz
2019-08-28 22:31 ` [PATCH 1/2] mbox: qcom: add APCS child device for QCS404 Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Jorge Ramirez-Ortiz @ 2019-08-26 16:46 UTC (permalink / raw)
To: jorge.ramirez-ortiz, jassisinghbrar, agross
Cc: niklas.cassel, bjorn.andersson, linux-arm-msm, linux-kernel
Use the correct macro when registering the platform device.
Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
index 76e1ad433b3f..dc198802bdf7 100644
--- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
+++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
@@ -96,7 +96,8 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
apcs->clk = platform_device_register_data(&pdev->dev,
"qcom-apcs-msm8916-clk",
- -1, NULL, 0);
+ PLATFORM_DEVID_NONE,
+ NULL, 0);
if (IS_ERR(apcs->clk))
dev_err(&pdev->dev, "failed to register APCS clk\n");
}
--
2.22.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] mbox: qcom: add APCS child device for QCS404
2019-08-26 16:46 [PATCH 1/2] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
2019-08-26 16:46 ` [PATCH 2/2] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
@ 2019-08-28 22:31 ` Stephen Boyd
2019-08-29 8:28 ` Jorge Ramirez
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2019-08-28 22:31 UTC (permalink / raw)
To: agross, jassisinghbrar, jorge.ramirez-ortiz
Cc: niklas.cassel, bjorn.andersson, linux-arm-msm, linux-kernel
Quoting Jorge Ramirez-Ortiz (2019-08-26 09:46:24)
> There is clock controller functionality in the APCS hardware block of
> qcs404 devices similar to msm8916.
>
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> index 705e17a5479c..76e1ad433b3f 100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -89,7 +89,11 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
> return ret;
> }
>
> - if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
> + platform_set_drvdata(pdev, apcs);
Why did this move? It's required in the child driver or something now?
Is it a Fixes sort of change?
> +
> + if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global") ||
> + of_device_is_compatible(np, "qcom,qcs404-apcs-apps-global")) {
Maybe this should be a compatible list instead of two calls to
of_device_is_compatible().
> +
> apcs->clk = platform_device_register_data(&pdev->dev,
> "qcom-apcs-msm8916-clk",
> -1, NULL, 0);
> @@ -97,8 +101,6 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "failed to register APCS clk\n");
> }
>
> - platform_set_drvdata(pdev, apcs);
> -
> return 0;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] mbox: qcom: add APCS child device for QCS404
2019-08-28 22:31 ` [PATCH 1/2] mbox: qcom: add APCS child device for QCS404 Stephen Boyd
@ 2019-08-29 8:28 ` Jorge Ramirez
0 siblings, 0 replies; 4+ messages in thread
From: Jorge Ramirez @ 2019-08-29 8:28 UTC (permalink / raw)
To: Stephen Boyd, agross, jassisinghbrar
Cc: niklas.cassel, bjorn.andersson, linux-arm-msm, linux-kernel
On 8/29/19 00:31, Stephen Boyd wrote:
> Quoting Jorge Ramirez-Ortiz (2019-08-26 09:46:24)
>> There is clock controller functionality in the APCS hardware block of
>> qcs404 devices similar to msm8916.
>>
>> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
>> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> ---
>> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> index 705e17a5479c..76e1ad433b3f 100644
>> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> @@ -89,7 +89,11 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
>> return ret;
>> }
>>
>> - if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
>> + platform_set_drvdata(pdev, apcs);
>
> Why did this move? It's required in the child driver or something now?
> Is it a Fixes sort of change?
>
>> +
>> + if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global") ||
>> + of_device_is_compatible(np, "qcom,qcs404-apcs-apps-global")) {
>
> Maybe this should be a compatible list instead of two calls to
> of_device_is_compatible().
>
>> +
>> apcs->clk = platform_device_register_data(&pdev->dev,
>> "qcom-apcs-msm8916-clk",
>> -1, NULL, 0);
>> @@ -97,8 +101,6 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
>> dev_err(&pdev->dev, "failed to register APCS clk\n");
>> }
>>
>> - platform_set_drvdata(pdev, apcs);
>> -
>> return 0;
>> }
>>
>
thanks stephen. posted v2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-29 8:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-26 16:46 [PATCH 1/2] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
2019-08-26 16:46 ` [PATCH 2/2] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
2019-08-28 22:31 ` [PATCH 1/2] mbox: qcom: add APCS child device for QCS404 Stephen Boyd
2019-08-29 8:28 ` Jorge Ramirez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®