* [PATCH] pinctrl: samsung: drop redundant drvdata assignment
@ 2024-04-30 6:03 Krzysztof Kozlowski
2024-04-30 7:27 ` André Draszik
2024-04-30 7:42 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-30 6:03 UTC (permalink / raw)
To: Krzysztof Kozlowski, Sylwester Nawrocki, Alim Akhtar,
Linus Walleij, André Draszik, linux-arm-kernel,
linux-samsung-soc, linux-gpio, linux-kernel
Cc: Krzysztof Kozlowski, kernel test robot
Fix W=1 warning:
drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpio_set_direction’:
drivers/pinctrl/samsung/pinctrl-samsung.c:633:42: warning: variable ‘drvdata’ set but not used [-Wunused-but-set-variable]
Fixes: f9c744747973 ("pinctrl: samsung: support a bus clock")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404300825.6lxLwvUY-lkp@intel.com/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/pinctrl/samsung/pinctrl-samsung.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index f4607b8493ff..623df65a5d6f 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -630,11 +630,9 @@ static int samsung_gpio_set_direction(struct gpio_chip *gc,
struct samsung_pin_bank *bank;
void __iomem *reg;
u32 data, mask, shift;
- struct samsung_pinctrl_drv_data *drvdata;
bank = gpiochip_get_data(gc);
type = bank->type;
- drvdata = bank->drvdata;
reg = bank->pctl_base + bank->pctl_offset
+ type->reg_offset[PINCFG_TYPE_FUNC];
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: samsung: drop redundant drvdata assignment
2024-04-30 6:03 [PATCH] pinctrl: samsung: drop redundant drvdata assignment Krzysztof Kozlowski
@ 2024-04-30 7:27 ` André Draszik
2024-04-30 7:42 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: André Draszik @ 2024-04-30 7:27 UTC (permalink / raw)
To: Krzysztof Kozlowski, Krzysztof Kozlowski, Sylwester Nawrocki,
Alim Akhtar, Linus Walleij, linux-arm-kernel, linux-samsung-soc,
linux-gpio, linux-kernel
Cc: kernel test robot
On Tue, 2024-04-30 at 08:03 +0200, Krzysztof Kozlowski wrote:
> Fix W=1 warning:
>
> drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpio_set_direction’:
> drivers/pinctrl/samsung/pinctrl-samsung.c:633:42: warning: variable ‘drvdata’ set but not used [-Wunused-but-set-variable]
>
> Fixes: f9c744747973 ("pinctrl: samsung: support a bus clock")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404300825.6lxLwvUY-lkp@intel.com/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: André Draszik <andre.draszik@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: samsung: drop redundant drvdata assignment
2024-04-30 6:03 [PATCH] pinctrl: samsung: drop redundant drvdata assignment Krzysztof Kozlowski
2024-04-30 7:27 ` André Draszik
@ 2024-04-30 7:42 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-30 7:42 UTC (permalink / raw)
To: Krzysztof Kozlowski, Sylwester Nawrocki, Alim Akhtar,
Linus Walleij, André Draszik, linux-arm-kernel,
linux-samsung-soc, linux-gpio, linux-kernel, Krzysztof Kozlowski
Cc: kernel test robot
On Tue, 30 Apr 2024 08:03:04 +0200, Krzysztof Kozlowski wrote:
> Fix W=1 warning:
>
> drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpio_set_direction’:
> drivers/pinctrl/samsung/pinctrl-samsung.c:633:42: warning: variable ‘drvdata’ set but not used [-Wunused-but-set-variable]
>
>
Applied, thanks!
[1/1] pinctrl: samsung: drop redundant drvdata assignment
https://git.kernel.org/pinctrl/samsung/c/e5b3732a9654f26d21647d9e7b4fec846f6d4810
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-30 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-30 6:03 [PATCH] pinctrl: samsung: drop redundant drvdata assignment Krzysztof Kozlowski
2024-04-30 7:27 ` André Draszik
2024-04-30 7:42 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®