From: Sekhar Nori <nsekhar@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, Kevin Hilman <khilman@kernel.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Axel Haslam <ahaslam@baylibre.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] ARM: davinci: don't mark vpif_input structures as 'const'
Date: Thu, 27 Jul 2017 16:24:55 +0530 [thread overview]
Message-ID: <5dc37564-2efe-d090-78a4-1702291b176d@ti.com> (raw)
In-Reply-To: <20170727101320.609258-1-arnd@arndb.de>
Hi Arnd,
On Thursday 27 July 2017 03:42 PM, Arnd Bergmann wrote:
> A change to the platform data definitions caused a warning in the board code:
>
> arch/arm/mach-davinci/board-dm646x-evm.c:680:13: error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
> arch/arm/mach-davinci/board-dm646x-evm.c:690:13: error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
You can replace these by:
arch/arm/mach-davinci/board-da850-evm.c:1221:13: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
arch/arm/mach-davinci/board-da850-evm.c:1231:13: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
to match with this patch.
>
> This is a bit unfortunate, since we generally like structure definitions to
> be const, but as this is legacy code, the easiest way out is still to
> remove the 'const' annotation here.
>
> Fixes: 4a5f8ae50b66 ("[media] davinci: vpif_capture: get subdevs from DT when available")
> Fixes: 231ce279e6e3 ("ARM: davinci: fix const warnings")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Looks like this slipped my testing since I had
CONFIG_DA850_UI_SD_VIDEO_PORT switched off. Thanks for catching it.
> ---
> I originally sent my fix on Jun 9, but Kevin had already applied an
> identical fix for two of the three affected files. This fixes the
> third one that his patch missed.
>
> I have a couple of other patches that I'm planning to apply directly
> to the fixes branch now, and would do the same for this one unless
> there are objections.
No problem. Thanks!
~Sekhar
next prev parent reply other threads:[~2017-07-27 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 10:12 Arnd Bergmann
2017-07-27 10:54 ` Sekhar Nori [this message]
2017-07-27 11:11 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dc37564-2efe-d090-78a4-1702291b176d@ti.com \
--to=nsekhar@ti.com \
--cc=ahaslam@baylibre.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®