mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] phy: sparx5-serdes: make it selectable for ARCH_LAN969X
@ 2025-10-31 12:18 Robert Marko
  2025-10-31 12:48 ` Gabor Juhos
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Robert Marko @ 2025-10-31 12:18 UTC (permalink / raw)
  To: vkoul, kishon, geert+renesas, herve.codina, linux-phy, linux-kernel
  Cc: luka.perkov, Robert Marko, Daniel Machon

LAN969x uses the SparX-5 SERDES driver, so make it selectable for
ARCH_LAN969X.

Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
Changes in v2:
* Rebase onto next-20251031
* Add Reviewed-by tag

 drivers/phy/microchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/microchip/Kconfig b/drivers/phy/microchip/Kconfig
index 2f0045e874ac..2e6d1224711e 100644
--- a/drivers/phy/microchip/Kconfig
+++ b/drivers/phy/microchip/Kconfig
@@ -6,7 +6,7 @@
 config PHY_SPARX5_SERDES
 	tristate "Microchip Sparx5 SerDes PHY driver"
 	select GENERIC_PHY
-	depends on ARCH_SPARX5 || COMPILE_TEST
+	depends on ARCH_SPARX5 || ARCH_LAN969X || COMPILE_TEST
 	depends on OF
 	depends on HAS_IOMEM
 	help
-- 
2.51.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] phy: sparx5-serdes: make it selectable for ARCH_LAN969X
  2025-10-31 12:18 [PATCH v2] phy: sparx5-serdes: make it selectable for ARCH_LAN969X Robert Marko
@ 2025-10-31 12:48 ` Gabor Juhos
  2025-12-06  8:51 ` Vladimir Oltean
  2025-12-23 17:34 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Gabor Juhos @ 2025-10-31 12:48 UTC (permalink / raw)
  To: Robert Marko, vkoul, kishon, geert+renesas, herve.codina,
	linux-phy, linux-kernel
  Cc: luka.perkov, Daniel Machon

Hi Robert,

2025. 10. 31. 13:18 keltezéssel, Robert Marko írta:
> LAN969x uses the SparX-5 SERDES driver, so make it selectable for
> ARCH_LAN969X.
> 
> Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> Changes in v2:
> * Rebase onto next-20251031
> * Add Reviewed-by tag
> 
>  drivers/phy/microchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/microchip/Kconfig b/drivers/phy/microchip/Kconfig
> index 2f0045e874ac..2e6d1224711e 100644
> --- a/drivers/phy/microchip/Kconfig
> +++ b/drivers/phy/microchip/Kconfig
> @@ -6,7 +6,7 @@
>  config PHY_SPARX5_SERDES
>  	tristate "Microchip Sparx5 SerDes PHY driver"
>  	select GENERIC_PHY
> -	depends on ARCH_SPARX5 || COMPILE_TEST
> +	depends on ARCH_SPARX5 || ARCH_LAN969X || COMPILE_TEST
>  	depends on OF
>  	depends on HAS_IOMEM
>  	help

This probably deserves a 'Fixes' tag, as it fixes the following warning:

    WARNING: unmet direct dependencies detected for PHY_SPARX5_SERDES
      Depends on [n]: (ARCH_SPARX5 [=n] || COMPILE_TEST [=n]) && OF [=y] && HAS_IOMEM [=y]
      Selected by [y]:
      - SPARX5_SWITCH [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y] && OF [=y] && (ARCH_SPARX5 [=n] || ARCH_LAN969X [=y] || COMPILE_TEST [=n]) && PTP_1588_CLOCK_OPTIONAL [=y] && (BRIDGE [=y] || BRIDGE [=y]=n [=n])

I have seen it on v6.18-rc3, and it is caused by commit 6287982aa549 ("net: ethernet:
microchip: sparx5: make it selectable for ARCH_LAN969X").

Tested-by: Gabor Juhos <j4g8y7@gmail.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] phy: sparx5-serdes: make it selectable for ARCH_LAN969X
  2025-10-31 12:18 [PATCH v2] phy: sparx5-serdes: make it selectable for ARCH_LAN969X Robert Marko
  2025-10-31 12:48 ` Gabor Juhos
@ 2025-12-06  8:51 ` Vladimir Oltean
  2025-12-23 17:34 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Oltean @ 2025-12-06  8:51 UTC (permalink / raw)
  To: vkoul, neil.armstrong, Robert Marko
  Cc: kishon, geert+renesas, herve.codina, linux-phy, linux-kernel,
	luka.perkov, Daniel Machon, Gabor Juhos

On Fri, Oct 31, 2025 at 01:18:12PM +0100, Robert Marko wrote:
> LAN969x uses the SparX-5 SERDES driver, so make it selectable for
> ARCH_LAN969X.
> 
> Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> Changes in v2:
> * Rebase onto next-20251031
> * Add Reviewed-by tag
> 
>  drivers/phy/microchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/microchip/Kconfig b/drivers/phy/microchip/Kconfig
> index 2f0045e874ac..2e6d1224711e 100644
> --- a/drivers/phy/microchip/Kconfig
> +++ b/drivers/phy/microchip/Kconfig
> @@ -6,7 +6,7 @@
>  config PHY_SPARX5_SERDES
>  	tristate "Microchip Sparx5 SerDes PHY driver"
>  	select GENERIC_PHY
> -	depends on ARCH_SPARX5 || COMPILE_TEST
> +	depends on ARCH_SPARX5 || ARCH_LAN969X || COMPILE_TEST
>  	depends on OF
>  	depends on HAS_IOMEM
>  	help
> -- 
> 2.51.1
> 
> 

From what I'm able to tell this patch wasn't picked up, but the issue is
appearing in builds and should be addressed soon, with the Fixes: tag
that Gabor points out.

Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] phy: sparx5-serdes: make it selectable for ARCH_LAN969X
  2025-10-31 12:18 [PATCH v2] phy: sparx5-serdes: make it selectable for ARCH_LAN969X Robert Marko
  2025-10-31 12:48 ` Gabor Juhos
  2025-12-06  8:51 ` Vladimir Oltean
@ 2025-12-23 17:34 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2025-12-23 17:34 UTC (permalink / raw)
  To: kishon, geert+renesas, herve.codina, linux-phy, linux-kernel,
	Robert Marko
  Cc: luka.perkov, Daniel Machon


On Fri, 31 Oct 2025 13:18:12 +0100, Robert Marko wrote:
> LAN969x uses the SparX-5 SERDES driver, so make it selectable for
> ARCH_LAN969X.
> 
> 

Applied, thanks!

[1/1] phy: sparx5-serdes: make it selectable for ARCH_LAN969X
      commit: d543d3eb06873f0ab8edb0d1f8364e9af93544a0

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-12-23 17:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-31 12:18 [PATCH v2] phy: sparx5-serdes: make it selectable for ARCH_LAN969X Robert Marko
2025-10-31 12:48 ` Gabor Juhos
2025-12-06  8:51 ` Vladimir Oltean
2025-12-23 17:34 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®