From: Krzysztof Kozlowski <krzk@kernel.org>
To: Deepa Guthyappa Madivalara <deepa.madivalara@oss.qualcomm.com>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: media: qcom,mahua-iris: Add Mahua video codec
Date: Tue, 17 Nov 2026 11:45:07 +0100 [thread overview]
Message-ID: <5de47ef8-58b6-40b7-9c62-f4c306cceb40@kernel.org> (raw)
In-Reply-To: <20261113-mahua_iris_enable-v1-1-b7107e1cbcaa@oss.qualcomm.com>
On 14/11/2026 04:09, Deepa Guthyappa Madivalara wrote:
> Add a devicetree binding for the Iris3.9 video encoder and decoder block
> found on the Qualcomm Mahua SoC. This is a single core derivative,
> leveraging most of Glymur data with the clks, resets present only
> for vcodec0 core.
>
> Signed-off-by: Deepa Guthyappa Madivalara <deepa.madivalara@oss.qualcomm.com>
> ---
> .../devicetree/bindings/media/qcom,mahua-iris.yaml | 243 +++++++++++++++++++++
> 1 file changed, 243 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,mahua-iris.yaml b/Documentation/devicetree/bindings/media/qcom,mahua-iris.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..cbae6bddf7fd4b67330ce47033874f3d349e5a3d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,mahua-iris.yaml
> @@ -0,0 +1,243 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/qcom,mahua-iris.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Mahua SoC Iris video encoder and decoder
> +
> +maintainers:
> + - Vikash Garodia <vikash.garodia@oss.qualcomm.com>
> +
> +description:
> + The Iris video processing unit on Qualcomm Mahua SoC is a video encode and
> + decode accelerator.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - const: qcom,mahua-iris
> + - const: qcom,glymur-iris
> + - const: qcom,mahua-iris
> +
I don't understand what you want to express at all. See DTS101 slides, I
gave the talk in Qualcomm office this year even.
Anyway, glymur is undocumented. There is nothing about dependencies in
top of the cover letter (sorry, not going to scroll further - you ALWAYS
put the most important information first), but anyway then it means this
is untestable or unreviewable.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-17 10:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 3:09 [PATCH 0/3] media: iris: Add support for mahua platform Deepa Guthyappa Madivalara
2026-11-14 3:09 ` [PATCH 1/3] dt-bindings: media: qcom,mahua-iris: Add Mahua video codec Deepa Guthyappa Madivalara
2026-11-17 10:42 ` Vishnu Reddy
2026-11-17 10:45 ` Krzysztof Kozlowski [this message]
2026-11-14 3:09 ` [PATCH 2/3] arm64: dts: qcom: mahua: add iris video codec node Deepa Guthyappa Madivalara
2026-11-17 10:39 ` Krzysztof Kozlowski
2026-11-14 3:09 ` [PATCH 3/3] media: iris: add mahua platform data and enable qcom,mahua-iris Deepa Guthyappa Madivalara
2026-11-17 10:29 ` Vishnu Reddy
2026-11-17 10:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5de47ef8-58b6-40b7-9c62-f4c306cceb40@kernel.org \
--to=krzk@kernel.org \
--cc=abelvesa@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=deepa.madivalara@oss.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®