* [PATCH] usb: cdns3: Fix issue with using incorrect PCI device function
@ 2023-03-08 12:44 Pawel Laszczak
2023-03-20 8:10 ` Roger Quadros
0 siblings, 1 reply; 2+ messages in thread
From: Pawel Laszczak @ 2023-03-08 12:44 UTC (permalink / raw)
To: peter.chen
Cc: gregkh, linux-usb, linux-kernel, rogerq, a-govindraju,
felipe.balbi, pawell, stable
PCI based platform can have more than two PCI functions.
USBSS PCI Glue driver during initialization should
consider only DRD/HOST/DEVICE PCI functions and
all other should be ignored. This patch adds additional
condition which causes that only DRD and HOST/DEVICE
function will be accepted.
cc: <stable@vger.kernel.org>
Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
---
drivers/usb/cdns3/cdns3-pci-wrap.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/usb/cdns3/cdns3-pci-wrap.c b/drivers/usb/cdns3/cdns3-pci-wrap.c
index deeea618ba33..1f6320d98a76 100644
--- a/drivers/usb/cdns3/cdns3-pci-wrap.c
+++ b/drivers/usb/cdns3/cdns3-pci-wrap.c
@@ -60,6 +60,11 @@ static struct pci_dev *cdns3_get_second_fun(struct pci_dev *pdev)
return NULL;
}
+ if (func->devfn != PCI_DEV_FN_HOST_DEVICE &&
+ func->devfn != PCI_DEV_FN_OTG) {
+ return NULL;
+ }
+
return func;
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] usb: cdns3: Fix issue with using incorrect PCI device function
2023-03-08 12:44 [PATCH] usb: cdns3: Fix issue with using incorrect PCI device function Pawel Laszczak
@ 2023-03-20 8:10 ` Roger Quadros
0 siblings, 0 replies; 2+ messages in thread
From: Roger Quadros @ 2023-03-20 8:10 UTC (permalink / raw)
To: Pawel Laszczak, peter.chen
Cc: gregkh, linux-usb, linux-kernel, a-govindraju, felipe.balbi, stable
On 08/03/2023 14:44, Pawel Laszczak wrote:
> PCI based platform can have more than two PCI functions.
> USBSS PCI Glue driver during initialization should
> consider only DRD/HOST/DEVICE PCI functions and
> all other should be ignored. This patch adds additional
> condition which causes that only DRD and HOST/DEVICE
> function will be accepted.
>
> cc: <stable@vger.kernel.org>
> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-20 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-08 12:44 [PATCH] usb: cdns3: Fix issue with using incorrect PCI device function Pawel Laszczak
2023-03-20 8:10 ` Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®