[PATCH] cdx: Fix device node reference leak in cdx_msi_domain_init

[PATCH] cdx: Fix device node reference leak in cdx_msi_domain_init

[Miaoqian Lin]

Add missing of_node_put() call to release
the device node reference obtained via of_parse_phandle().

Fixes: 0e439ba38e61 ("cdx: add MSI support for CDX bus")
Cc: stable@vger.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/cdx/cdx_msi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cdx/cdx_msi.c b/drivers/cdx/cdx_msi.c
index 3388a5d1462c..91b95422b263 100644
--- a/drivers/cdx/cdx_msi.c
+++ b/drivers/cdx/cdx_msi.c
@@ -174,6 +174,7 @@ struct irq_domain *cdx_msi_domain_init(struct device *dev)
 	}
 
 	parent = irq_find_matching_fwnode(of_fwnode_handle(parent_node), DOMAIN_BUS_NEXUS);
+	of_node_put(parent_node);
 	if (!parent || !msi_get_domain_info(parent)) {
 		dev_err(dev, "unable to locate ITS domain\n");
 		return NULL;
-- 
2.35.1

Re: [PATCH] cdx: Fix device node reference leak in cdx_msi_domain_init

[Markus Elfring]

> Add missing of_node_put() call to release
> the device node reference obtained via of_parse_phandle().

You may occasionally put more than 58 characters into text lines
of such a change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc4#n638


How do you think about to append parentheses to the function name
in the summary phrase?

Regards,
Markus

Re: [PATCH] cdx: Fix device node reference leak in cdx_msi_domain_init

[Greg Kroah-Hartman]

On Tue, Sep 02, 2025 at 11:05:45AM +0200, Markus Elfring wrote:
> > Add missing of_node_put() call to release
> > the device node reference obtained via of_parse_phandle().
> 
> You may occasionally put more than 58 characters into text lines
> of such a change description.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc4#n638
> 
> 
> How do you think about to append parentheses to the function name
> in the summary phrase?
> 
> Regards,
> Markus
> 

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot

Re: [PATCH] cdx: Fix device node reference leak in cdx_msi_domain_init

[Gupta, Nipun]

On 02-09-2025 14:19, Miaoqian Lin wrote:
> Add missing of_node_put() call to release
> the device node reference obtained via of_parse_phandle().
> 
> Fixes: 0e439ba38e61 ("cdx: add MSI support for CDX bus")
> Cc: stable@vger.kernel.org
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Acked-by: Nipun Gupta <nipun.gupta@amd.com>