From: James Smart <james.smart@broadcom.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: prevent potential null pointer dereference
Date: Mon, 29 May 2017 16:06:28 -0700 [thread overview]
Message-ID: <5e0120e9-418d-c051-cd3e-03c39ff8f627@broadcom.com> (raw)
In-Reply-To: <20170523150928.GA24570@embeddedgus>
Looks good
Signed-off-by: James Smart <james.smart@broadcom.com>
-- james
On 5/23/2017 8:09 AM, Gustavo A. R. Silva wrote:
> Null check at line 966: if (ndlp) {, implies that ndlp might be NULL.
> Functions lpfc_nlp_set_state() and lpfc_issue_els_prli() dereference
> pointer ndlp. Include these function calls inside the IF block that
> tests pointer ndlp.
>
> Addresses-Coverity-ID: 1401856
>
next prev parent reply other threads:[~2017-05-29 23:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 15:09 Gustavo A. R. Silva
2017-05-29 23:06 ` James Smart [this message]
2017-06-01 2:45 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e0120e9-418d-c051-cd3e-03c39ff8f627@broadcom.com \
--to=james.smart@broadcom.com \
--cc=dick.kennedy@broadcom.com \
--cc=garsilva@embeddedor.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®