From: Jinyang He <hejinyang@loongson.cn>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] LoongArch: Correct the definition of is_branch_ins()
Date: Sat, 17 Dec 2022 09:49:09 +0800 [thread overview]
Message-ID: <5e051682-c4fa-64d7-8567-149b5bd7d403@loongson.cn> (raw)
In-Reply-To: <e65ce2d5-a154-6912-ab01-b0dc158acaaa@loongson.cn>
On 2022-12-16 14:11, Tiezhu Yang wrote:
>
>
> On 12/16/2022 11:18 AM, Jinyang He wrote:
>> Hi, Tiezhu,
>>
>>
>> On 2022-12-14 16:30, Tiezhu Yang wrote:
>>> The current definition of is_branch_ins() is not correct,
>>
>> But the branch instruction opcode only use the high 6 bits,
>
> Yes, I noticed that, the logic result of current code is right,
> but it seems a little strange (only consider reg1i21_format)
> at the first glance, the initial aim of this patch is to make
> it theoretically correct, maybe it is not the best change.
>
> I think we can neglect the instruction formats and check the
> high 6 bits instead, what do you think of the following change?
We defined many instruction format because of variable-width opcode
field and parameter field. IMHO if there is no way to solve that problem
really, keeping original codes is better. That depends on the
maintainers, of course.
Thanks,
Jinyang
>
> diff --git a/arch/loongarch/include/asm/inst.h
> b/arch/loongarch/include/asm/inst.h
> index c00e151..fd31752 100644
> --- a/arch/loongarch/include/asm/inst.h
> +++ b/arch/loongarch/include/asm/inst.h
> @@ -329,8 +329,8 @@ static inline bool is_pc_ins(union
> loongarch_instruction *ip)
>
> static inline bool is_branch_ins(union loongarch_instruction *ip)
> {
> - return ip->reg1i21_format.opcode >= beqz_op &&
> - ip->reg1i21_format.opcode <= bgeu_op;
> + return ((ip->word >> 26) & 0x3f) >= beqz_op &&
> + ((ip->word >> 26) & 0x3f) <= bgeu_op;
> }
>
> Thanks,
> Tiezhu
>
>
>
prev parent reply other threads:[~2022-12-17 1:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 8:30 Tiezhu Yang
2022-12-16 3:18 ` Jinyang He
2022-12-16 6:11 ` Tiezhu Yang
2022-12-17 1:49 ` Jinyang He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e051682-c4fa-64d7-8567-149b5bd7d403@loongson.cn \
--to=hejinyang@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®