From: Jinyang He <hejinyang@loongson.cn>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] LoongArch: Correct the definition of is_branch_ins()
Date: Fri, 16 Dec 2022 11:18:48 +0800 [thread overview]
Message-ID: <e89c80c7-53e5-5fec-d66b-4b375aa85d10@loongson.cn> (raw)
In-Reply-To: <1671006659-23859-1-git-send-email-yangtiezhu@loongson.cn>
Hi, Tiezhu,
On 2022-12-14 16:30, Tiezhu Yang wrote:
> The current definition of is_branch_ins() is not correct,
But the branch instruction opcode only use the high 6 bits, [1]. That's
meaningless because it is the same as the original result. If we care
too much about the details of instruction format, we will lose a lot of
tricks on LoongArch instruction coding.
[1]
https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html#table-of-instruction-encoding
> it was
> first introduced in commit 49aef111e2da ("LoongArch: Add prologue
> unwinder support"), in fact, there exist three branch instruction
> formats rather than only reg1i21_format.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> arch/loongarch/include/asm/inst.h | 27 +++++++++++++++++++++++++--
> 1 file changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/arch/loongarch/include/asm/inst.h b/arch/loongarch/include/asm/inst.h
> index c00e151..42be39be 100644
> --- a/arch/loongarch/include/asm/inst.h
> +++ b/arch/loongarch/include/asm/inst.h
> @@ -329,8 +329,31 @@ static inline bool is_pc_ins(union loongarch_instruction *ip)
>
> static inline bool is_branch_ins(union loongarch_instruction *ip)
> {
> - return ip->reg1i21_format.opcode >= beqz_op &&
> - ip->reg1i21_format.opcode <= bgeu_op;
> + switch (ip->reg0i26_format.opcode) {
> + case b_op:
> + case bl_op:
> + return true;
> + }
> +
> + switch (ip->reg1i21_format.opcode) {
> + case beqz_op:
> + case bnez_op:
> + case bceqz_op:
> + return true;
> + }
> +
> + switch (ip->reg2i16_format.opcode) {
> + case jirl_op:
> + case beq_op:
> + case bne_op:
> + case blt_op:
> + case bge_op:
> + case bltu_op:
> + case bgeu_op:
> + return true;
> + }
> +
> + return false;
> }
>
> static inline bool is_ra_save_ins(union loongarch_instruction *ip)
next prev parent reply other threads:[~2022-12-16 3:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 8:30 Tiezhu Yang
2022-12-16 3:18 ` Jinyang He [this message]
2022-12-16 6:11 ` Tiezhu Yang
2022-12-17 1:49 ` Jinyang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e89c80c7-53e5-5fec-d66b-4b375aa85d10@loongson.cn \
--to=hejinyang@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®