* [PATCH] drm/amd/display: Document num_rmcm_3dluts in mpc_color_caps
@ 2025-08-23 20:25 Kavithesh A.S
2025-08-27 20:02 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: Kavithesh A.S @ 2025-08-23 20:25 UTC (permalink / raw)
To: amd-gfx
Cc: dri-devel, linux-kernel, skhan, harry.wentland, sunpeng.li,
siqueira, alexander.deucher, christian.koenig, airlied, simona,
Kavithesh A.S
Fix a kernel-doc warning by documenting the num_rmcm_3dluts member of struct mpc_color_caps.
This is my first patch submission to the kernel, feedback is welcome
Signed-off-by: Kavithesh A.S <kavitheshnitt@gmail.com>
---
drivers/gpu/drm/amd/display/dc/dc.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
index 59c077561..06f05979b 100644
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -234,6 +234,7 @@ struct lut3d_caps {
* @ogam_ram: programmable out gamma LUT
* @ocsc: output color space conversion matrix
* @num_3dluts: MPC 3D LUT; always assumes a preceding shaper LUT
+ * @num_rmcm_3dluts: number of RMCM 3D LUTS supported
* @shared_3d_lut: shared 3D LUT flag. Can be either DPP or MPC, but single
* instance
* @ogam_rom_caps: pre-definied curve caps for regamma 1D LUT
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amd/display: Document num_rmcm_3dluts in mpc_color_caps
2025-08-23 20:25 [PATCH] drm/amd/display: Document num_rmcm_3dluts in mpc_color_caps Kavithesh A.S
@ 2025-08-27 20:02 ` Alex Deucher
2025-08-27 20:10 ` Melissa Wen
0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2025-08-27 20:02 UTC (permalink / raw)
To: Kavithesh A.S
Cc: amd-gfx, dri-devel, linux-kernel, skhan, harry.wentland,
sunpeng.li, siqueira, alexander.deucher, christian.koenig,
airlied, simona
Applied. Thanks!
Alex
On Sat, Aug 23, 2025 at 4:25 PM Kavithesh A.S <kavitheshnitt@gmail.com> wrote:
>
> Fix a kernel-doc warning by documenting the num_rmcm_3dluts member of struct mpc_color_caps.
>
> This is my first patch submission to the kernel, feedback is welcome
>
> Signed-off-by: Kavithesh A.S <kavitheshnitt@gmail.com>
> ---
> drivers/gpu/drm/amd/display/dc/dc.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index 59c077561..06f05979b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -234,6 +234,7 @@ struct lut3d_caps {
> * @ogam_ram: programmable out gamma LUT
> * @ocsc: output color space conversion matrix
> * @num_3dluts: MPC 3D LUT; always assumes a preceding shaper LUT
> + * @num_rmcm_3dluts: number of RMCM 3D LUTS supported
> * @shared_3d_lut: shared 3D LUT flag. Can be either DPP or MPC, but single
> * instance
> * @ogam_rom_caps: pre-definied curve caps for regamma 1D LUT
> --
> 2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amd/display: Document num_rmcm_3dluts in mpc_color_caps
2025-08-27 20:02 ` Alex Deucher
@ 2025-08-27 20:10 ` Melissa Wen
2025-08-27 20:13 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: Melissa Wen @ 2025-08-27 20:10 UTC (permalink / raw)
To: Alex Deucher, Kavithesh A.S
Cc: amd-gfx, dri-devel, linux-kernel, skhan, harry.wentland,
sunpeng.li, siqueira, alexander.deucher, christian.koenig,
airlied, simona
On 27/08/2025 17:02, Alex Deucher wrote:
> Applied. Thanks!
>
> Alex
>
> On Sat, Aug 23, 2025 at 4:25 PM Kavithesh A.S <kavitheshnitt@gmail.com> wrote:
>> Fix a kernel-doc warning by documenting the num_rmcm_3dluts member of struct mpc_color_caps.
>>
>> This is my first patch submission to the kernel, feedback is welcome
>>
>> Signed-off-by: Kavithesh A.S <kavitheshnitt@gmail.com>
>> ---
>> drivers/gpu/drm/amd/display/dc/dc.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
>> index 59c077561..06f05979b 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dc.h
>> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
>> @@ -234,6 +234,7 @@ struct lut3d_caps {
>> * @ogam_ram: programmable out gamma LUT
>> * @ocsc: output color space conversion matrix
>> * @num_3dluts: MPC 3D LUT; always assumes a preceding shaper LUT
>> + * @num_rmcm_3dluts: number of RMCM 3D LUTS supported
A bit late to comment, but I think you should keep the "always assumes a
preceding shaper LUT" part.
This info is still very useful and links shaper LUT caps to this attribute.
Melissa
>> * @shared_3d_lut: shared 3D LUT flag. Can be either DPP or MPC, but single
>> * instance
>> * @ogam_rom_caps: pre-definied curve caps for regamma 1D LUT
>> --
>> 2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amd/display: Document num_rmcm_3dluts in mpc_color_caps
2025-08-27 20:10 ` Melissa Wen
@ 2025-08-27 20:13 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2025-08-27 20:13 UTC (permalink / raw)
To: Melissa Wen
Cc: Kavithesh A.S, amd-gfx, dri-devel, linux-kernel, skhan,
harry.wentland, sunpeng.li, siqueira, alexander.deucher,
christian.koenig, airlied, simona
On Wed, Aug 27, 2025 at 4:10 PM Melissa Wen <mwen@igalia.com> wrote:
>
>
>
> On 27/08/2025 17:02, Alex Deucher wrote:
> > Applied. Thanks!
> >
> > Alex
> >
> > On Sat, Aug 23, 2025 at 4:25 PM Kavithesh A.S <kavitheshnitt@gmail.com> wrote:
> >> Fix a kernel-doc warning by documenting the num_rmcm_3dluts member of struct mpc_color_caps.
> >>
> >> This is my first patch submission to the kernel, feedback is welcome
> >>
> >> Signed-off-by: Kavithesh A.S <kavitheshnitt@gmail.com>
> >> ---
> >> drivers/gpu/drm/amd/display/dc/dc.h | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> >> index 59c077561..06f05979b 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> >> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> >> @@ -234,6 +234,7 @@ struct lut3d_caps {
> >> * @ogam_ram: programmable out gamma LUT
> >> * @ocsc: output color space conversion matrix
> >> * @num_3dluts: MPC 3D LUT; always assumes a preceding shaper LUT
> >> + * @num_rmcm_3dluts: number of RMCM 3D LUTS supported
> A bit late to comment, but I think you should keep the "always assumes a
> preceding shaper LUT" part.
> This info is still very useful and links shaper LUT caps to this attribute.
I'll add that before I push it.
Alex
>
> Melissa
>
> >> * @shared_3d_lut: shared 3D LUT flag. Can be either DPP or MPC, but single
> >> * instance
> >> * @ogam_rom_caps: pre-definied curve caps for regamma 1D LUT
> >> --
> >> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-27 20:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-23 20:25 [PATCH] drm/amd/display: Document num_rmcm_3dluts in mpc_color_caps Kavithesh A.S
2025-08-27 20:02 ` Alex Deucher
2025-08-27 20:10 ` Melissa Wen
2025-08-27 20:13 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®