Re: [PATCH asahi-soc/dt 01/10] dt-bindings: arm: apple: apple,pmgr: Add A7-A11 compatibles

[Hector Martin <marcan@marcan.st>]

On 2024/10/29 16:41, Krzysztof Kozlowski wrote:
> On Tue, Oct 29, 2024 at 09:03:59AM +0800, Nick Chan wrote:
>> The blocks found on Apple A7-A11 SoCs are compatible with the existing
>> driver so add their per-SoC compatibles.
>>
>> Signed-off-by: Nick Chan <towinchenmi@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
>> index 673277a7a224..5001f4d5a0dc 100644
>> --- a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
>> +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
>> @@ -22,6 +22,11 @@ properties:
>>    compatible:
>>      items:
>>        - enum:
>> +          - apple,s5l8960x-pmgr
>> +          - apple,t7000-pmgr
>> +          - apple,s8000-pmgr
>> +          - apple,t8010-pmgr
>> +          - apple,t8015-pmgr
> 
> Assuming you keep the existing order of entries in this file, which is
> different than usually expected: alphanumeric.
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Yeah, it's a bit ad-hoc but essentially "by release date" with a fork at
t6000. So:

- First the ancient s5l series
- Then all the t/sXXXX chips up to t8103 (M1) (numeric order, ignoring
prefix letter)
- Then the rest of the "baseline" Ax,Mx chips that continue after M1,
which are all numbered t8xxx (numeric order)
- Finally the t6xxx series (Mx Pro/Mx Max), which forks the timeline and
numbering after t8103/M1 (M1 Pro = t6000).

Unless there's significant objection I'd like to keep this pattern, it
makes sense from the POV of people working on these chips.

- Hector