From: Hector Martin <marcan@marcan.st>
To: Nick Chan <towinchenmi@gmail.com>,
Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH asahi-soc/dt 00/10] Add PMGR nodes for Apple A7-A11 SoCs
Date: Fri, 1 Nov 2024 21:41:13 +0900 [thread overview]
Message-ID: <23074410-ffe2-4f68-a983-67cec430f68f@marcan.st> (raw)
In-Reply-To: <20241029010526.42052-1-towinchenmi@gmail.com>
On 2024/10/29 10:03, Nick Chan wrote:
> This series adds the PMGR nodes and all known power state subnodes for
> Apple A7-A11 SoCs, along with the associated dt-bindings.
>
> ---
> Nick Chan (10):
> dt-bindings: arm: apple: apple,pmgr: Add A7-A11 compatibles
> dt-bindings: arm: apple: apple,pmgr-pwrstate: Add A7-A11 compatibles
> arm64: dts: apple: s5l8960x: Add PMGR node
> arm64: dts: apple: t7000: Add PMGR node
> arm64: dts: apple: t7001: Add PMGR node
> arm64: dts: apple: s8000: Add PMGR nodes
> arm64: dts: apple: s8001: Add PMGR nodes
> arm64: dts: apple: t8010: Add PMGR nodes
> arm64: dts: apple: t8011: Add PMGR nodes
> arm64: dts: apple: t8015: Add PMGR nodes
>
> .../bindings/arm/apple/apple,pmgr.yaml | 5 +
> .../bindings/power/apple,pmgr-pwrstate.yaml | 5 +
> arch/arm64/boot/dts/apple/s5l8960x-5s.dtsi | 4 +
> arch/arm64/boot/dts/apple/s5l8960x-air1.dtsi | 4 +
> .../arm64/boot/dts/apple/s5l8960x-common.dtsi | 1 +
> arch/arm64/boot/dts/apple/s5l8960x-mini2.dtsi | 4 +
> arch/arm64/boot/dts/apple/s5l8960x-pmgr.dtsi | 610 ++++++++++++
> arch/arm64/boot/dts/apple/s5l8960x.dtsi | 13 +
> .../arm64/boot/dts/apple/s800-0-3-common.dtsi | 1 +
> arch/arm64/boot/dts/apple/s8000-pmgr.dtsi | 757 ++++++++++++++
> arch/arm64/boot/dts/apple/s8000.dtsi | 22 +
> arch/arm64/boot/dts/apple/s8001-common.dtsi | 1 +
> .../arm64/boot/dts/apple/s8001-j98a-j99a.dtsi | 26 +
> arch/arm64/boot/dts/apple/s8001-j98a.dts | 1 +
> arch/arm64/boot/dts/apple/s8001-j99a.dts | 1 +
> arch/arm64/boot/dts/apple/s8001-pmgr.dtsi | 823 ++++++++++++++++
> arch/arm64/boot/dts/apple/s8001.dtsi | 22 +
> arch/arm64/boot/dts/apple/s800x-6s.dtsi | 4 +
> arch/arm64/boot/dts/apple/s800x-ipad5.dtsi | 4 +
> arch/arm64/boot/dts/apple/s800x-se.dtsi | 4 +
> arch/arm64/boot/dts/apple/t7000-6.dtsi | 4 +
> arch/arm64/boot/dts/apple/t7000-handheld.dtsi | 4 +
> arch/arm64/boot/dts/apple/t7000-j42d.dts | 1 +
> arch/arm64/boot/dts/apple/t7000-mini4.dtsi | 4 +
> arch/arm64/boot/dts/apple/t7000-n102.dts | 4 +
> arch/arm64/boot/dts/apple/t7000-pmgr.dtsi | 641 ++++++++++++
> arch/arm64/boot/dts/apple/t7000.dtsi | 14 +
> arch/arm64/boot/dts/apple/t7001-air2.dtsi | 1 +
> arch/arm64/boot/dts/apple/t7001-pmgr.dtsi | 650 ++++++++++++
> arch/arm64/boot/dts/apple/t7001.dtsi | 13 +
> arch/arm64/boot/dts/apple/t8010-7.dtsi | 4 +
> arch/arm64/boot/dts/apple/t8010-common.dtsi | 1 +
> arch/arm64/boot/dts/apple/t8010-ipad6.dtsi | 4 +
> arch/arm64/boot/dts/apple/t8010-n112.dts | 4 +
> arch/arm64/boot/dts/apple/t8010-pmgr.dtsi | 772 +++++++++++++++
> arch/arm64/boot/dts/apple/t8010.dtsi | 22 +
> arch/arm64/boot/dts/apple/t8011-common.dtsi | 1 +
> arch/arm64/boot/dts/apple/t8011-pmgr.dtsi | 807 +++++++++++++++
> arch/arm64/boot/dts/apple/t8011-pro2.dtsi | 8 +
> arch/arm64/boot/dts/apple/t8011.dtsi | 22 +
> arch/arm64/boot/dts/apple/t8015-common.dtsi | 1 +
> arch/arm64/boot/dts/apple/t8015-pmgr.dtsi | 931 ++++++++++++++++++
> arch/arm64/boot/dts/apple/t8015.dtsi | 21 +
> 43 files changed, 6246 insertions(+)
> create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/s8000-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/s8001-j98a-j99a.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/s8001-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t7000-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t7001-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t8010-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t8011-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t8015-pmgr.dtsi
>
>
> base-commit: 5c9de6f45db36b8a74c12e448cf9db87c97bf1e5
I'm not going to review the actual pmgr spam (I assume you did the usual
thing and autogenerated it with the m1n1 scripts and then fixed some
things up by hand, as we do), since really the only useful way to
validate this is testing and I don't have these devices (nor am I
familiar with any peculiarities).
Skimming the rest of the changes it looks reasonable, so:
Acked-by: Hector Martin <marcan@marcan.st>
Would be nice to get at least a cursory review from the DT folks, I'll
apply to the SoC tree after that (please poke me via direct/non-PATCH
email if I miss it, those go in a different inbox).
- Hector
prev parent reply other threads:[~2024-11-01 12:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 1:03 Nick Chan
2024-10-29 1:03 ` [PATCH asahi-soc/dt 01/10] dt-bindings: arm: apple: apple,pmgr: Add A7-A11 compatibles Nick Chan
2024-10-29 7:41 ` Krzysztof Kozlowski
2024-11-01 12:33 ` Hector Martin
2024-11-01 15:39 ` Krzysztof Kozlowski
2024-10-29 1:04 ` [PATCH asahi-soc/dt 02/10] dt-bindings: arm: apple: apple,pmgr-pwrstate: " Nick Chan
2024-10-29 7:41 ` Krzysztof Kozlowski
2024-10-29 1:04 ` [PATCH asahi-soc/dt 03/10] arm64: dts: apple: s5l8960x: Add PMGR node Nick Chan
2024-10-29 1:04 ` [PATCH asahi-soc/dt 04/10] arm64: dts: apple: t7000: " Nick Chan
2024-11-01 13:04 ` Rob Herring
2024-11-01 15:09 ` Nick Chan
2024-10-29 1:04 ` [PATCH asahi-soc/dt 05/10] arm64: dts: apple: t7001: " Nick Chan
2024-10-29 1:04 ` [PATCH asahi-soc/dt 06/10] arm64: dts: apple: s8000: Add PMGR nodes Nick Chan
2024-10-29 1:04 ` [PATCH asahi-soc/dt 07/10] arm64: dts: apple: s8001: " Nick Chan
2024-10-29 1:04 ` [PATCH asahi-soc/dt 08/10] arm64: dts: apple: t8010: " Nick Chan
2024-10-29 1:04 ` [PATCH asahi-soc/dt 09/10] arm64: dts: apple: t8011: " Nick Chan
2024-10-29 1:04 ` [PATCH asahi-soc/dt 10/10] arm64: dts: apple: t8015: " Nick Chan
2024-11-01 12:41 ` Hector Martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23074410-ffe2-4f68-a983-67cec430f68f@marcan.st \
--to=marcan@marcan.st \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
--cc=towinchenmi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®